[freeside-users] 4.1 Bug report: "Change Payment Information" in self service fails silently and disables contact

[Erreu Gedmon]

Name: "Change Payment Information" in self service fails silently and disables contact
Description: "Change Payment Information" in self service fails silently (it does not update cust_payby)
but displays "Information updated successfully". Additionally, it updates cust_contact.selfservice_access
and cust_contact.classnum to NULL
Expected: The submitted data should be accepted or produce an error.
Reproduce: Login to selfservice, choose "Change Payment Information", enter valid data, choose "Save payment information."
Affects: 4.0, 4.1, 4.2~git-1
Workaround: Disable "Change payment information" and use "Recharge my account with a credit card" instead.
Notes: 3.92~git-1 is unaffected.
1. "Recharge my account with a credit card" does successfully update cust_payby without updating cust_contact.selfservice_access
2. After selecting "Change Payment Information", the UI does not automatically display
the default data entry form, the drop down must be selected multiple times, and when the form appears
it does not contain the record from cust_payby as it previosuly did in 3.x.
3. Updating the billing or service address does work, but also updates
cust_contact.selfservice_access and cust_contact.classnum to NULL.

-- 

Erreu Gedmon

--
"You see persons and things not as they are but as you are."
        -- Anthony De Mello