[freeside-users] Patch for LesNet cdr data

[Sebastien Perreault]

Hi,

 Thanks for the comments and the cleanup is done.

 Regards,

On Tue, May 3, 2011 at 4:41 PM, Ivan Kohler <ivan at freeside.biz> wrote:
> On Tue, May 03, 2011 at 04:33:05PM -0400, Sebastien Perreault wrote:
>> Hi,
>>
>>  I've written this cdr module for LesNet (www.les.net) VOIP Service
>> provider cdr data for easy import.
>>
>>  The patch was tested on Freeside 2.1.1, I did not upgrade to 2.1.2 yet.
>
> Since this is a new CDR format, I don't think there are any differences,
> you should be able to use this with pretty much any version.
>
>>  Let me know if it's the right way to contribute or not?
>
> This works.  My only comment on your module is that you should remove
> the unnecessary/extraneous items:
>  - use vars() that aren't used
>  - use Time:::Local and HTTP::Date
>  - sub skip
>
> I'll be happy to add this to the release once that's cleaned up.
>
> Thanks for your contribution!
>
> --
> _ivan
> _______________________________________________
> freeside-users mailing list
> freeside-users at freeside.biz
> http://420.am/cgi-bin/mailman/listinfo/freeside-users
>



-- 
Sebastien Perrreault
Partner
Les Technologies Alesium Inc
P: 514-977-4298
F: 514-221-3668
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lesnet.pm.gz
Type: application/x-gzip
Size: 320 bytes
Desc: not available
URL: <http://420.am/pipermail/freeside-users/attachments/20110503/13344b83/attachment.bin>