[freeside] Small Patch

[ivan]

Hmm, I'm not certain about this patch.  *All* of the scp commands in
svc_acct.export, not just the ones you patched, copy a file to a file. 
This seems to work with both "classic" ssh1 and OpenSSH.  You are using
the commercial SSH 2?  Is this behavior documented?  What's the error
message you get when it fails? 

I think I'd be more comfortable with something that chose the appopriate
flags for your each of scp.  In this case you wouldn't need to check the
version as such; you could probably stat the source file, and only turn on
the scp `-r' if it's a directory (in perl, if `-d $filename' is true). 


The `-q' flag is a separate issue.

The ssh 1.2.26 scp manpage says:

       -q    Turn off statistics display.

The openssh 1.2.3 scp manpages says:

	-q      Disables the progress meter.

What does the commercial SSH 2 scp manpage say about -q?

(Hmm, I wonder if -q turns off error reporting in all versions)

On Thu, Jul 13, 2000 at 11:25:57AM -0500, Kenny Elliott wrote:
> Ivan:
> 
>   I was having a problem exporting the icradius databases with
> svc_acct.export and here is what I tracked down.
> 
>   The scp command that was meant to copy these files was executing
> with the -r switch. Since the target of this command was a file and
> not a directory it would silently error out since the -q switch was
> also present. Not wanting to change these switches for fear of
> breaking something else I simply changed the offending scp in
> svc_acct.export to copy to the appropriate directory instead if the
> file itself. I believe this will allow SSH.pm's scp function to work
> with ssh versions 1 and 2 and openssh. A patch is attached.
> 
>   The explanation is longer than the patch :)
> 
> 
> ---
> Kenny Elliott <kenny at neoserve.com>
> System Administration / Web Development
> NeoServe, L.L.C.
> 
> P: (504) 649-9321
> F: (504) 781-6007
> 



-- 
meow
_ivan