[freeside-commits] branch FREESIDE_4_BRANCH updated. 9f0cf3c4adeb541827d1620576db11e99599bca6

Ivan ivan at 420.am
Thu Nov 3 17:25:41 PDT 2016


The branch, FREESIDE_4_BRANCH has been updated
       via  9f0cf3c4adeb541827d1620576db11e99599bca6 (commit)
      from  ff8440c2e6db69857e88437dcd0f13219abd71e1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9f0cf3c4adeb541827d1620576db11e99599bca6
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Nov 3 17:25:35 2016 -0700

    Format email addresses w/Email::Address instead of ad-hoc, fixes issues emailing companies with commas, RT#73241

diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm
index 167f55b..f9cb342 100644
--- a/FS/FS/cust_main.pm
+++ b/FS/FS/cust_main.pm
@@ -20,15 +20,17 @@ use base qw( FS::cust_main::Packages
 require 5.006;
 use strict;
 use Carp;
+use Try::Tiny;
 use Scalar::Util qw( blessed );
-use Time::Local qw(timelocal);
-use Data::Dumper;
+use List::Util qw(min);
 use Tie::IxHash;
+use File::Temp; #qw( tempfile );
+use Data::Dumper;
+use Time::Local qw(timelocal);
 use Date::Format;
 #use Date::Manip;
-use File::Temp; #qw( tempfile );
+use Email::Address;
 use Business::CreditCard 0.28;
-use List::Util qw(min);
 use FS::UID qw( dbh driver_name );
 use FS::Record qw( qsearchs qsearch dbdef regexp_sql );
 use FS::Cursor;
@@ -3276,8 +3278,9 @@ sub contact_list_email {
   my @emails;
   foreach my $contact (@contacts) {
     foreach my $contact_email ($contact->contact_email) {
-      push @emails,
-        $contact->firstlast . ' <' . $contact_email->emailaddress . '>';
+      push @emails,  Email::Address->new( $contact->firstlast,
+                                          $contact_email->emailaddress
+                     )->format;
     }
   }
   @emails;

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main.pm |   15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)




More information about the freeside-commits mailing list