[freeside-commits] branch master updated. 39b05a617a55fe0bb072cde02a5c1b5b16301f62

Ivan ivan at 420.am
Thu Nov 3 17:25:28 PDT 2016


The branch, master has been updated
       via  39b05a617a55fe0bb072cde02a5c1b5b16301f62 (commit)
       via  145bc8c83c8a132e5cd171a34b0f45948674d535 (commit)
      from  f822e27a1e00594332ffa487a1c284234c5580a6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 39b05a617a55fe0bb072cde02a5c1b5b16301f62
Merge: 145bc8c f822e27
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Nov 3 17:25:05 2016 -0700

    Merge branch 'master' of git.freeside.biz:/home/git/freeside


commit 145bc8c83c8a132e5cd171a34b0f45948674d535
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Nov 3 16:56:00 2016 -0700

    Format email addresses w/Email::Address instead of ad-hoc, fixes issues emailing companies with commas, RT#73241

diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm
index 2136ad2..55a31f8 100644
--- a/FS/FS/cust_main.pm
+++ b/FS/FS/cust_main.pm
@@ -20,16 +20,17 @@ use base qw( FS::cust_main::Packages
 require 5.006;
 use strict;
 use Carp;
+use Try::Tiny;
 use Scalar::Util qw( blessed );
-use Time::Local qw(timelocal);
-use Data::Dumper;
+use List::Util qw(min);
 use Tie::IxHash;
+use File::Temp; #qw( tempfile );
+use Data::Dumper;
+use Time::Local qw(timelocal);
 use Date::Format;
 #use Date::Manip;
-use File::Temp; #qw( tempfile );
+use Email::Address;
 use Business::CreditCard 0.28;
-use List::Util qw(min);
-use Try::Tiny;
 use FS::UID qw( dbh driver_name );
 use FS::Record qw( qsearchs qsearch dbdef regexp_sql );
 use FS::Cursor;
@@ -3060,8 +3061,9 @@ sub contact_list_email {
   my @emails;
   foreach my $contact (@contacts) {
     foreach my $contact_email ($contact->contact_email) {
-      push @emails,
-        $contact->firstlast . ' <' . $contact_email->emailaddress . '>';
+      push @emails,  Email::Address->new( $contact->firstlast,
+                                          $contact_email->emailaddress
+                     )->format;
     }
   }
   @emails;

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main.pm |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)




More information about the freeside-commits mailing list