[freeside-commits] freeside/FS/FS part_pkg.pm,1.56.2.6,1.56.2.7

Ivan,,, ivan at wavetail.420.am
Wed Jul 9 13:37:23 PDT 2008


Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail.420.am:/tmp/cvs-serv17706

Modified Files:
      Tag: FREESIDE_1_7_BRANCH
	part_pkg.pm 
Log Message:
should avoid spurious uninitialized value warnings on upgrade

Index: part_pkg.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/part_pkg.pm,v
retrieving revision 1.56.2.6
retrieving revision 1.56.2.7
diff -u -d -r1.56.2.6 -r1.56.2.7
--- part_pkg.pm	2 May 2008 02:00:14 -0000	1.56.2.6
+++ part_pkg.pm	9 Jul 2008 20:37:20 -0000	1.56.2.7
@@ -376,7 +376,12 @@
   my $pkg_svc = $options{'pkg_svc'} || {};
   foreach my $part_svc ( qsearch('part_svc', {} ) ) {
     my $quantity = $pkg_svc->{$part_svc->svcpart} || 0;
-    my $primary_svc = $options{'primary_svc'} == $part_svc->svcpart ? 'Y' : '';
+    my $primary_svc =
+      ( defined($options{'primary_svc'})
+        && $options{'primary_svc'} == $part_svc->svcpart
+      )
+        ? 'Y'
+        : '';
 
     my $old_pkg_svc = qsearchs('pkg_svc', {
       'pkgpart' => $old->pkgpart,



More information about the freeside-commits mailing list