[freeside-commits] freeside/FS/FS part_pkg.pm,1.72,1.73

Ivan,,, ivan at wavetail.420.am
Wed Jul 9 13:37:17 PDT 2008


Update of /home/cvs/cvsroot/freeside/FS/FS
In directory wavetail.420.am:/tmp/cvs-serv17694

Modified Files:
	part_pkg.pm 
Log Message:
should avoid spurious uninitialized value warnings on upgrade

Index: part_pkg.pm
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/FS/part_pkg.pm,v
retrieving revision 1.72
retrieving revision 1.73
diff -u -d -r1.72 -r1.73
--- part_pkg.pm	19 Jun 2008 03:18:17 -0000	1.72
+++ part_pkg.pm	9 Jul 2008 20:37:14 -0000	1.73
@@ -342,7 +342,13 @@
   my $pkg_svc = $options->{'pkg_svc'} || {};
   foreach my $part_svc ( qsearch('part_svc', {} ) ) {
     my $quantity = $pkg_svc->{$part_svc->svcpart} || 0;
-    my $primary_svc = $options->{'primary_svc'} == $part_svc->svcpart ? 'Y' : '';
+    my $primary_svc =
+      ( defined($options->{'primary_svc'})
+        && $options->{'primary_svc'} == $part_svc->svcpart
+      )
+        ? 'Y'
+        : '';
+
 
     my $old_pkg_svc = qsearchs('pkg_svc', {
       'pkgpart' => $old->pkgpart,



More information about the freeside-commits mailing list