[freeside-commits] freeside/rt/html/Ticket/Elements ShowTransactionAttachments, 1.1.1.3, 1.1.1.3.2.1

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/rt/html/Ticket/Elements
In directory wavetail:/tmp/cvs-serv17820

Modified Files:
      Tag: FREESIDE_1_7_BRANCH
	ShowTransactionAttachments 
Log Message:
turn off Text::Quoted usage, it segfaults and its optional

Index: ShowTransactionAttachments
===================================================================
RCS file: /home/cvs/cvsroot/freeside/rt/html/Ticket/Elements/ShowTransactionAttachments,v
retrieving revision 1.1.1.3
retrieving revision 1.1.1.3.2.1
diff -u -d -r1.1.1.3 -r1.1.1.3.2.1
--- ShowTransactionAttachments	17 Oct 2006 08:49:18 -0000	1.1.1.3
+++ ShowTransactionAttachments	14 Sep 2007 02:14:31 -0000	1.1.1.3.2.1
@@ -136,8 +136,14 @@
             # if it's a text/plain show the body
             elsif ( $message->ContentType =~ m{^(text|message|text)}i ) {
 
-                eval { $content = Text::Quoted::extract($content); };
-                if ($@) { 1; }
+                #don't want to use this even if it is installed, its
+                #segfaulting on weird characters and silently truncating the
+                #ticket history output
+                #see:
+                # r44838 at pinglin: jesse | 2006-11-14 15:53:18 -0500
+                # * Move Text::Quoted back to being a run-time require. So that it's possible to turn off the feature if it causes your perl to segfault. (Text::Tabs is...not robust in the face of perl bugs)
+                #eval { $content = Text::Quoted::extract($content); };
+                #if ($@) { 1; }
 
                 $m->comp(
                     'ShowMessageStanza',