[freeside-commits] freeside/rt/html/Ticket/Elements ShowTransactionAttachments, 1.1.1.4, 1.2
Ivan,,,
ivan at wavetail.420.am
Thu Sep 13 19:14:12 PDT 2007
Update of /home/cvs/cvsroot/freeside/rt/html/Ticket/Elements
In directory wavetail:/tmp/cvs-serv17783
Modified Files:
ShowTransactionAttachments
Log Message:
turn off Text::Quoted usage, it segfaults and its optional
Index: ShowTransactionAttachments
===================================================================
RCS file: /home/cvs/cvsroot/freeside/rt/html/Ticket/Elements/ShowTransactionAttachments,v
retrieving revision 1.1.1.4
retrieving revision 1.2
diff -u -d -r1.1.1.4 -r1.2
--- ShowTransactionAttachments 2 Aug 2007 19:56:02 -0000 1.1.1.4
+++ ShowTransactionAttachments 14 Sep 2007 02:14:07 -0000 1.2
@@ -139,8 +139,14 @@
# if it's a text/plain show the body
elsif ( $message->ContentType =~ m{^(text|message|text)}i ) {
- eval { require Text::Quoted; $content = Text::Quoted::extract($content); };
- if ($@) { 1; }
+ #don't want to use this even if it is installed, its
+ #segfaulting on weird characters and silently truncating the
+ #ticket history output
+ #see:
+ # r44838 at pinglin: jesse | 2006-11-14 15:53:18 -0500
+ # * Move Text::Quoted back to being a run-time require. So that it's possible to turn off the feature if it causes your perl to segfault. (Text::Tabs is...not robust in the face of perl bugs)
+ #eval { require Text::Quoted; $content = Text::Quoted::extract($content); };
+ #if ($@) { 1; }
$m->comp(
'ShowMessageStanza',
More information about the freeside-commits
mailing list