[freeside-commits] freeside/httemplate/misc/process recharge_svc.html, 1.2.2.2, 1.2.2.3

Ivan,,, ivan at wavetail.420.am
Fri Jul 13 16:52:34 PDT 2007


Update of /home/cvs/cvsroot/freeside/httemplate/misc/process
In directory wavetail:/tmp/cvs-serv6059/httemplate/misc/process

Modified Files:
      Tag: FREESIDE_1_7_BRANCH
	recharge_svc.html 
Log Message:
fix race condition where ->apply_payments_and_credits could double-apply in rare cases

Index: recharge_svc.html
===================================================================
RCS file: /home/cvs/cvsroot/freeside/httemplate/misc/process/recharge_svc.html,v
retrieving revision 1.2.2.2
retrieving revision 1.2.2.3
diff -u -d -r1.2.2.2 -r1.2.2.3
--- recharge_svc.html	12 Apr 2007 02:27:37 -0000	1.2.2.2
+++ recharge_svc.html	13 Jul 2007 23:52:32 -0000	1.2.2.3
@@ -57,7 +57,7 @@
 %
 %    my $old_balance = $cust_main->balance;
 %    $error ||= $cust_main->bill;
-%    $cust_main->apply_payments_and_credits unless $error;
+%    $error ||= $cust_main->apply_payments_and_credits;
 %    my $bill_error = $cust_main->collect('realtime' => 1) unless $error;
 %    $error ||= "Failed to collect - $bill_error"
 %      if $cust_main->balance > $old_balance && $cust_main->balance > 0



More information about the freeside-commits mailing list