[freeside-commits] freeside/FS/bin freeside-prepaidd,1.3,1.3.2.1

[Ivan,,,]

Update of /home/cvs/cvsroot/freeside/FS/bin
In directory wavetail:/tmp/cvs-serv6059/FS/bin

Modified Files:
      Tag: FREESIDE_1_7_BRANCH
	freeside-prepaidd 
Log Message:
fix race condition where ->apply_payments_and_credits could double-apply in rare cases

Index: freeside-prepaidd
===================================================================
RCS file: /home/cvs/cvsroot/freeside/FS/bin/freeside-prepaidd,v
retrieving revision 1.3
retrieving revision 1.3.2.1
diff -u -d -r1.3 -r1.3.2.1
--- freeside-prepaidd	17 Nov 2006 10:16:10 -0000	1.3
+++ freeside-prepaidd	13 Jul 2007 23:52:31 -0000	1.3.2.1
@@ -52,9 +52,11 @@
         warn "Error billing customer #". $cust_main->custnum;
 	next;
       }
-      #$b_error = $cust_main->apply_payments_and_credits;
-      $b_error = $cust_main->apply_payments;
-      $b_error = $cust_main->apply_credits;
+      $b_error = $cust_main->apply_payments_and_credits;
+      if ( $b_error ) {
+        warn "Error applying payments&credits, customer #". $cust_main->custnum;
+	next;
+      }
 
       $work_cust_pkg = qsearchs('cust_pkg', { 'pkgnum' => $work_cust_pkg->pkgnum } );