[freeside] Our humongous patch

[ivan]

On Mon, Dec 11, 2000 at 12:27:55PM -0800, Brad Dameron wrote:
> 
> On Mon, 11 Dec 2000, ivan wrote:
> 
> > On Sun, Dec 10, 2000 at 11:29:25PM -0800, Kristian Hoffmann wrote:
> > > 
> > > On Fri, 8 Dec 2000, ivan wrote:
> > > 
> > > > > Removed cust_credit and merged it into cust_pay so credits would apply to
> > > > >       invoices after they were created.  Because of this, we can remove
> > > > >       the cust_bill.owed field and calculate invoice balances on the fly.
> > > > >       This removes the ability to post a credit before an invoice is
> > > > >       generated.  Included script fix-credits converts old-style credits
> > > > >       into new credits.
> > > > 
> > > > Hmm, I'm all for removing the cust_bill.owed field, but I would prefer
> > > > to keep cust_credit.
> > > 
> > > Yes, removing cust_credit was not entirely necessary.  The main problem we
> > > were having was that people in billing would credit an invoice and then
> > > re-order another package.  Since the credits were being issued after the
> > > invoices, they weren't being calculated into the owed fields in
> > > cust_bill.  The cust_bill->owed method fixes that though.  I forgot what
> > > my point was.
> > 
> > Can't help you with that :), but like I said, I totally agree with moving
> > owed from a database field to a dynamically calculated method.
> > 
> > > Actually, would you mind adding a patch for cust_bill->void
> > > method?  Voiding an invoice would be a cleaner way to cancel it rather
> > > than issuing credits.
> > 
> > What would you want voiding an invoice to do, precisely?
> > 
> > > In general, freeside works properly and does the
> > > right thing (tm).  The problem is the people that wait until after they've
> > > been billed to decide they want to change packages.
> > > 
> > > Narf,
> > > 
> > > -Kristian Hoffmann
> > > <khoff at pc-intouch.com>
> > > 
> > 
> > -- 
> > meow
> > _ivan
> 
> 
> Has this humungous patch been added to the current CVS so I can grab it
> before I start on some of my patch's?

No, it hasn't been applied yet.  It requires changes to the database
schema and I haven't been sent an appropriate patch for the
schema source in bin/fs-setup.

It may be easier to take the raw MySQL dump and the DBIx::DBSchema perl
module (which is descended from FS::dbdef) to dump the MySQL schema into
the format fs-setup uses, with the DBIx::DBSchema pretty_write method. 

-- 
meow
_ivan