[freeside-devel] Fixes to 5.xgit

[Fernando M. Kiernan]

Hello!
Sorry for bothering you with this and for top posting!!

If you can give some feedback about the pull requests on github it would be
great as I have many other patches to push. Of course there is no need to
commit them to freeside as I just want to know if the format is correct so I
can generate other patches in the same way.

Regards!

Fernando M. Kiernan
Imágenes Digitales S.A.
www.imagenesdigitales.com.ar


> -----Original Message-----
> From: freeside-devel [mailto:freeside-devel-bounces at freeside.biz] On
> Behalf Of Fernando M. Kiernan
> Sent: Saturday, January 30, 2016 10:34 AM
> To: 'Freeside development mailing list' <freeside-devel at freeside.biz>
> Subject: Re: [freeside-devel] Fixes to 5.xgit
> 
> Hi
> 
> >On Fri, Jan 29, 2016 at 10:04:29PM -0300, Fernando M. Kiernan wrote:
> >> Hi, I've some little fixes to 5.xgit (may be some of them should be
> >> backported to 4.x, or even 3.x,  after commiting to HEAD).
> >>
> >> By now there are 4 minor fixes, 2 more to add es_AR locale and ARS
> >> money, and 1 to localize the header of the pages.
> >>
> >> Which is the best way to send these to you for commiting???
> >
> >The best way would be a git pull request against our repo, with each
> logical change separate.
> >
> >Alternative ways would be patches sent to this mailing list (unified
> >diff
> please) or git pull requests against the github repo (for corporate folks
> behind very restrictive firewalls).
> 
> I created 4 new pull requests on github, please tell me if the way they
are is
> acceptable so I can continue pushing other patches I have pending.
> 
> TIA
> Fernando
> 
> >
> >In all casees keeping each logical change separate would be appreciated.
> >
> >Thanks for your contributions!
> >
> --
> Ivan Kohler
> President and Head Geek, Freeside Internet Services, Inc.
> http://freeside.biz/ Debian GNU/Linux developer  |  CPAN author  |  cat
> person  |  ski addict
> 
> _______________________________________________
> freeside-devel mailing list
> freeside-devel at freeside.biz
> http://freeside.biz/cgi-bin/mailman/listinfo/freeside-devel
> 
> _______________________________________________
> freeside-devel mailing list
> freeside-devel at freeside.biz
> http://freeside.biz/cgi-bin/mailman/listinfo/freeside-devel