[freeside-devel] Some fixes to review

[Fernando M. Kiernan]

> -----Original Message-----
> From: freeside-devel-bounces at freeside.biz [mailto:freeside-devel-bounces at freeside.biz] On
> Behalf Of Ivan Kohler
> Sent: Sunday, January 19, 2014 3:20 AM
> To: Freeside development mailing list
> Subject: Re: [freeside-devel] Some fixes to review
> 
> 
> Thanks for your contribution!
> 

You're welcome, this an awesome software!!

.....

> 
> >       - Fix Ticketing System Permissions. (now you can restrict access to or hide all
Ticket
> > system for a Freeside User)
> 
> This doesn't seem entirely right.
> 
> You change everything in menu.html to be based off the RT "Show Ticket"
> or "Superuser".  This makes sense for Reports->Tickets.  I'm not sure it
> makes sense for Tools->Ticketing (don't some of these have their own RT
> permissions?).  It definitely doesn't make sense for
> Configuration->Ticketing, where you replace the existing check for the
> RT right "ShowConfigTab".

Yes, you're right I'll rework it...

> 
> You also seem to have change the ticket _search_ to be based on the
> "ShowConfigTab" right, which definitely isn't right.
> 

My mistake (cut and paste) the original idea was to use "ShowTicket".

I'll redo the entire commit.

Regards
Fernando

.....
> 
> --
> _ivan
> _______________________________________________
> freeside-devel mailing list
> freeside-devel at freeside.biz
> http://freeside.biz/cgi-bin/mailman/listinfo/freeside-devel