pkg_svc entries for zero-qty services

Ricardo SIGNES rjbs+freeside-devel at icgroup.com
Fri Jun 10 12:02:08 PDT 2005


Is there any reason whatsoever to have zero-quantity entries in pkg_svc?
I may be misreading things, but I can't see what purpose they serve.
When new services are added, old active packages are not updated to hvae
the records for the new service.

It seems like the only purpose they could serve is some sort of obscure
reminder of what services were around when the pkg_svc was updated.

If they're not needed, I'd like to submit a patch to change the logic in
FS::part_pkg::insert to skip zero-quantity services.  (This is part of
my missiono f making ->pkg_svc easier to subclass.)

Thanks.

-- 
rjbs



More information about the freeside-devel mailing list