[freeside-commits] branch master updated. 1fc8addc56f8daf12397da568eb1ac1b27fd3984

Ivan Kohler ivan at freeside.biz
Wed Aug 18 11:11:30 PDT 2021


The branch, master has been updated
       via  1fc8addc56f8daf12397da568eb1ac1b27fd3984 (commit)
      from  57bb423fe457ba4e13726877f53bcdf944f828f8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 1fc8addc56f8daf12397da568eb1ac1b27fd3984
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Wed Aug 18 11:11:29 2021 -0700

    quiet warnings about CGI::param in list context

diff --git a/httemplate/edit/process/cust_main.cgi b/httemplate/edit/process/cust_main.cgi
index baacd5e7e..18017fdb9 100755
--- a/httemplate/edit/process/cust_main.cgi
+++ b/httemplate/edit/process/cust_main.cgi
@@ -44,7 +44,7 @@ my $error = '';
 
 $cgi->param('tax','') unless defined $cgi->param('tax');
 
-$cgi->param('refnum', (split(/:/, ($cgi->param('refnum'))[0] ))[0] );
+$cgi->param('refnum', (split(/:/, ($cgi->multi_param('refnum'))[0] ))[0] );
 
 #my @invoicing_list = split( /\s*\,\s*/, $cgi->param('invoicing_list') );
 #push @invoicing_list, 'POST' if $cgi->param('invoicing_list_POST');
diff --git a/httemplate/edit/process/elements/ApplicationCommon.html b/httemplate/edit/process/elements/ApplicationCommon.html
index b7501d462..5007319b8 100644
--- a/httemplate/edit/process/elements/ApplicationCommon.html
+++ b/httemplate/edit/process/elements/ApplicationCommon.html
@@ -55,8 +55,12 @@ my $cust_main = qsearchs('cust_main', { 'custnum' => $src->custnum } )
 my $custnum = $cust_main->custnum;
 
 my @subnames = grep { /.+/ } map { /^subnum(\d+)$/ ? $1 : '' } $cgi->param;
-my @subitems = map { [ $cgi->param("subnum$_"), $cgi->param("subamount$_"), $cgi->param("taxXlocationnum$_") ] }
-               @subnames;
+my @subitems = map { [ scalar($cgi->param("subnum$_")),
+                       scalar($cgi->param("subamount$_")),
+                       scalar($cgi->param("taxXlocationnum$_"))
+                     ]
+                   }
+                 @subnames;
 { local $^W = 0; @subitems = grep { $_->[1] + 0 } @subitems; }
 
 my %options = ();
diff --git a/httemplate/misc/xmlhttp-cust_main-display_recurring.html b/httemplate/misc/xmlhttp-cust_main-display_recurring.html
index dd9ed3bb5..6c9cf69a9 100644
--- a/httemplate/misc/xmlhttp-cust_main-display_recurring.html
+++ b/httemplate/misc/xmlhttp-cust_main-display_recurring.html
@@ -1,7 +1,7 @@
 <% encode_json($return) %>\
 <%init>
 
-my %arg = $cgi->param('arg');
+my %arg = $cgi->multi_param('arg');
 my $custnum = delete($arg{'custnum'});
 
 my $error;
diff --git a/httemplate/search/cust_event.html b/httemplate/search/cust_event.html
index 8bbd1af24..56bf76778 100644
--- a/httemplate/search/cust_event.html
+++ b/httemplate/search/cust_event.html
@@ -163,7 +163,7 @@ die "access denied"
               || $cgi->param('pkgnum')  =~ /^(\d+)$/
             );
 
-my @statuses = $cgi->param('event_status');
+my @statuses = $cgi->multi_param('event_status');
 my $title = 'Billing events';
 if ( $statuses[0] eq 'failed' and !defined($statuses[1]) ) {
   # tweak the title if we're showing only failed events
diff --git a/httemplate/search/cust_main.html b/httemplate/search/cust_main.html
index 46e35da7f..8ef068f26 100755
--- a/httemplate/search/cust_main.html
+++ b/httemplate/search/cust_main.html
@@ -70,7 +70,7 @@ for my $param ( @scalars ) {
 
 #lists
 for my $param (qw( classnum refnum pkg_classnum )) {
-  $search_hash{$param} = [ $cgi->param($param) ];
+  $search_hash{$param} = [ $cgi->multi_param($param) ];
 }
 
 my $params = $cgi->Vars;
diff --git a/httemplate/search/log.html b/httemplate/search/log.html
index 9be0b7d0a..96a6f5b64 100644
--- a/httemplate/search/log.html
+++ b/httemplate/search/log.html
@@ -216,7 +216,9 @@ $cgi->param('max_level', 5) unless defined($cgi->param('max_level'));
 
 my %search = ();
 $search{'date'} = [ FS::UI::Web::parse_beginning_ending($cgi) ];
-$search{'level'} = [ $cgi->param('min_level'), $cgi->param('max_level') ];
+$search{'level'} = [ scalar($cgi->param('min_level')),
+                     scalar($cgi->param('max_level'))
+                   ];
 foreach my $param (qw(agentnum context context_height tablename tablenum custnum message)) {
   if ( $cgi->param($param) ) {
     $search{$param} = $cgi->param($param);

-----------------------------------------------------------------------

Summary of changes:
 httemplate/edit/process/cust_main.cgi                    | 2 +-
 httemplate/edit/process/elements/ApplicationCommon.html  | 8 ++++++--
 httemplate/misc/xmlhttp-cust_main-display_recurring.html | 2 +-
 httemplate/search/cust_event.html                        | 2 +-
 httemplate/search/cust_main.html                         | 2 +-
 httemplate/search/log.html                               | 4 +++-
 6 files changed, 13 insertions(+), 7 deletions(-)




More information about the freeside-commits mailing list