[freeside-commits] branch FREESIDE_4_BRANCH updated. 87dff918320e959b9d35b8a3bf5b8b1ca96952f1

[Ivan Kohler]

The branch, FREESIDE_4_BRANCH has been updated
       via  87dff918320e959b9d35b8a3bf5b8b1ca96952f1 (commit)
      from  3a440e369dce7dfeecafdb0ffebb36bbd1d2fd28 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 87dff918320e959b9d35b8a3bf5b8b1ca96952f1
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Aug 29 15:34:32 2019 -0700

    these errors are fatal for now, and fix them, RT#83146, RT#40206

diff --git a/FS/bin/freeside-cdr-asterisk_sql b/FS/bin/freeside-cdr-asterisk_sql
index 97e475868..cd765deee 100755
--- a/FS/bin/freeside-cdr-asterisk_sql
+++ b/FS/bin/freeside-cdr-asterisk_sql
@@ -133,9 +133,9 @@ while ( my $row = $sth->fetchrow_hashref ) {
   $cdr->amaflags('') unless $cdr->amaflags =~ /^(\d+)$/;
 
   if ( my $error = $cdr->insert ) {
-    log_msg( error =>
-      sprintf 'Non-fatal failure to import acctid(%s) from table(%s): %s',
-        $row->acctid,
+    log_and_die( error =>
+      sprintf 'Fatal failure to import uniqueid(%s) from table(%s): %s',
+        $row->{'uniqueid'},
         $table,
         $error
     );
@@ -161,9 +161,9 @@ while ( my $row = $sth->fetchrow_hashref ) {
     if ( $dbi->do($usql, @args) ) {
       $updates++;
     } else {
-      log_msg( error =>
-        sprintf 'Non-fatal failure set status(done) acctid(%s) table(%s): %s',
-          $row->acctid,
+      log_and_die( error =>
+        sprintf 'Fatal failure set status(done) uniqueid(%s) table(%s): %s',
+          $row->{'uniqueid'},
           $table,
           $dbi->errstr
       );

-----------------------------------------------------------------------

Summary of changes:
 FS/bin/freeside-cdr-asterisk_sql | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)