[freeside-commits] branch FREESIDE_4_BRANCH updated. 6383208b0f004ddcb26c74788595dce6673863f8

Ivan Kohler ivan at freeside.biz
Thu Sep 13 10:51:05 PDT 2018


The branch, FREESIDE_4_BRANCH has been updated
       via  6383208b0f004ddcb26c74788595dce6673863f8 (commit)
       via  24fcbda43464e5ee5a342a52f6c5780e12693402 (commit)
      from  bc552f2fba7fd376a2f036a7dc02b58a48fa31b0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6383208b0f004ddcb26c74788595dce6673863f8
Merge: 24fcbda43 bc552f2fb
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu Sep 13 10:51:01 2018 -0700

    Merge branch 'FREESIDE_4_BRANCH' of git.freeside.biz:/home/git/freeside into FREESIDE_4_BRANCH


commit 24fcbda43464e5ee5a342a52f6c5780e12693402
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Tue Jan 31 17:29:10 2017 -0800

    add condition_sql optimization to "Package definitions" condition, RT#74456

diff --git a/FS/FS/part_event/Condition/pkg_pkgpart.pm b/FS/FS/part_event/Condition/pkg_pkgpart.pm
index 6adef8eb6..d5b5c8daa 100644
--- a/FS/FS/part_event/Condition/pkg_pkgpart.pm
+++ b/FS/FS/part_event/Condition/pkg_pkgpart.pm
@@ -25,15 +25,16 @@ sub option_fields {
 sub condition {
   my( $self, $cust_pkg) = @_;
 
-  #XXX test
   my $if_pkgpart = $self->option('if_pkgpart') || {};
   $if_pkgpart->{ $cust_pkg->pkgpart };
 
 }
 
-#XXX 
-#sub condition_sql {
-#
-#}
+sub condition_sql {
+  my( $self, $table ) = @_;
+  
+  'cust_pkg.pkgpart IN '.
+    $self->condition_sql_option_option_integer('if_pkgpart');
+}
 
 1;

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/part_event/Condition/pkg_pkgpart.pm | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)




More information about the freeside-commits mailing list