[freeside-commits] branch FREESIDE_3_BRANCH updated. 280684f99e1f9f58a83966fcbaa1bb8f37029fe7

[Mitch Jackson]

The branch, FREESIDE_3_BRANCH has been updated
       via  280684f99e1f9f58a83966fcbaa1bb8f37029fe7 (commit)
      from  376a9227af02de5862eb9252d22aca3c845995db (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 280684f99e1f9f58a83966fcbaa1bb8f37029fe7
Author: Mitch Jackson <mitch at freeside.biz>
Date:   Sat Dec 1 01:01:03 2018 -0500

    RT# 81830 Critical log event for corrupted invoice data

diff --git a/FS/FS/Template_Mixin.pm b/FS/FS/Template_Mixin.pm
index d1d84a7c9..61ea45408 100644
--- a/FS/FS/Template_Mixin.pm
+++ b/FS/FS/Template_Mixin.pm
@@ -26,6 +26,7 @@ use FS::pkg_category;
 use FS::pkg_class;
 use FS::invoice_mode;
 use FS::L10N;
+use FS::Log;
 
 $DEBUG = 0;
 $me = '[FS::Template_Mixin]';
@@ -3475,6 +3476,27 @@ sub _items_cust_bill_pkg {
           if $DEBUG > 1;
  
         my $cust_pkg = $cust_bill_pkg->cust_pkg;
+
+        unless ( $cust_pkg ) {
+          # There is no related row in cust_pkg for this cust_bill_pkg.pkgnum.
+          # This invoice may have been broken by an unusual combination
+          # of manually editing package dates, and aborted package changes
+          # when the manually edited dates used are nonsensical.
+
+          my $error = sprintf
+            'cust_bill_pkg(billpkgnum:%s) '.
+            'is missing related row in cust_pkg(pkgnum:%s)! '.
+            'cust_bill(invnum:%s) is corrupted by bad database data, '.
+            'and should be investigated',
+              $cust_bill_pkg->billpkgnum,
+              $cust_bill_pkg->pkgnum,
+              $cust_bill_pkg->invnum;
+
+          FS::Log->new('FS::cust_bill_pkg')->critical( $error );
+          warn $error;
+          next;
+        }
+
         my $part_pkg = $cust_pkg->part_pkg;
 
         # which pkgpart to show for display purposes?

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/Template_Mixin.pm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)