[freeside-commits] branch FREESIDE_4_BRANCH updated. 3a09582cbae17d3c1cfd0c9530b5ef6c2fe659a1

[Ivan Kohler]

The branch, FREESIDE_4_BRANCH has been updated
       via  3a09582cbae17d3c1cfd0c9530b5ef6c2fe659a1 (commit)
      from  3a532ec892ee17b58691d0c04baead999ebdbab9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3a09582cbae17d3c1cfd0c9530b5ef6c2fe659a1
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Mon Jul 16 18:41:46 2018 -0700

    harmless, but don't do a string comparison on numbers anyway, RT#79825

diff --git a/FS/FS/svc_IP_Mixin.pm b/FS/FS/svc_IP_Mixin.pm
index 8b2b5f17e..4b402fa8d 100644
--- a/FS/FS/svc_IP_Mixin.pm
+++ b/FS/FS/svc_IP_Mixin.pm
@@ -80,7 +80,7 @@ sub svc_ip_check {
   my $error = $self->ip_check;
   return $error if $error;
   if ( my $router = $self->router ) {
-    if ( grep { $_->routernum eq $router->routernum } $self->allowed_routers ) {
+    if ( grep { $_->routernum == $router->routernum } $self->allowed_routers ) {
       return '';
     } else {
       return 'Router '.$router->routername.' not available for this service';

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/svc_IP_Mixin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)