[freeside-commits] branch FREESIDE_4_BRANCH updated. 12a92604de8428e1d3b1be20e2bda2bd31bd5aeb

[Ivan Kohler]

The branch, FREESIDE_4_BRANCH has been updated
       via  12a92604de8428e1d3b1be20e2bda2bd31bd5aeb (commit)
      from  3848ca2c96115f150965b6cd20d41c3b64ffb2ac (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 12a92604de8428e1d3b1be20e2bda2bd31bd5aeb
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Tue Jan 9 15:43:42 2018 -0800

    fix employee pw change, RT#79010, RT#32456

diff --git a/FS/FS/Auth/internal.pm b/FS/FS/Auth/internal.pm
index eea4870d7..dfc5f301d 100644
--- a/FS/FS/Auth/internal.pm
+++ b/FS/FS/Auth/internal.pm
@@ -48,7 +48,9 @@ sub change_password {
   my($self, $access_user, $new_password) = @_;
 
   # do nothing if the password is unchanged
-  return if $self->authenticate( $access_user, $new_password );
+  #XXX breaks password changes in employee edit ($access_user object already
+  # has new [plaintext] password)
+  #return if $self->authenticate( $access_user, $new_password );
 
   $self->change_password_fields( $access_user, $new_password );
 

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/Auth/internal.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)