[freeside-commits] branch master updated. 24504360a41565105569992bf4ff5273b5f88bf7

[Mitch Jackson]

The branch, master has been updated
       via  24504360a41565105569992bf4ff5273b5f88bf7 (commit)
       via  302e2522922019c8a1c6251188066ad10ae07bdc (commit)
       via  304cf07be79b45930dcd5cb49cdf24aceaa3ebd9 (commit)
      from  56501725dadae47e0592a7d0652afce526784b60 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 24504360a41565105569992bf4ff5273b5f88bf7
Author: Mitch Jackson <mitch at freeside.biz>
Date:   Sat Apr 14 12:56:14 2018 -0500

    POD Documentation

diff --git a/FS/FS/cust_bill.pm b/FS/FS/cust_bill.pm
index fe3867449..0a735f7ec 100644
--- a/FS/FS/cust_bill.pm
+++ b/FS/FS/cust_bill.pm
@@ -2716,7 +2716,7 @@ sub _items_svc_phone_sections {
 
 }
 
-=sub _items_usage_class_summary OPTIONS
+=item _items_usage_class_summary OPTIONS
 
 Returns a list of detail items summarizing the usage charges on this
 invoice.  Each one will have 'amount', 'description' (the usage charge name),
@@ -2765,7 +2765,7 @@ sub _items_usage_class_summary {
   return @l;
 }
 
-=sub _items_previous()
+=item _items_previous()
 
   Returns an array of hashrefs, each hashref representing a line-item on
   the current bill for previous unpaid invoices.
@@ -2899,7 +2899,7 @@ sub _items_previous {
 
 }
 
-=sub _items_previous_total
+=item _items_previous_total
 
   Return sum of amounts from all items returned by _items_previous
   Results will vary based on invoicing conf flags
@@ -2949,7 +2949,7 @@ sub __items_previous_map_invoice {
   }
 }
 
-=sub _items_credits()
+=item _items_credits()
 
   Return array of hashrefs containing credits to be shown as line-items
   when rendering this bill.
@@ -3088,7 +3088,7 @@ sub _items_credits {
   @return;
 }
 
-=sub _items_credits_total
+=item _items_credits_total
 
   Return the total of al items from _items_credits
   Will vary based on invoice display conf flag
@@ -3104,7 +3104,7 @@ sub _items_credits_total {
 
 
 
-=sub _items_credits_postbill()
+=item _items_credits_postbill()
 
   Returns an array of hashrefs for credits where
   - Credit issued after this invoice
@@ -3146,7 +3146,7 @@ sub _items_credits_postbill {
   }} @cust_credit_bill;
 }
 
-=sub _items_payments_postbill()
+=item _items_payments_postbill()
 
   Returns an array of hashrefs for payments where
   - Payment occured after this invoice
@@ -3182,7 +3182,7 @@ sub _items_payments_postbill {
   }} @cust_bill_pay;
 }
 
-=sub _items_payments()
+=item _items_payments()
 
   Return array of hashrefs containing payments to be shown as line-items
   when rendering this bill.
@@ -3300,7 +3300,7 @@ sub _items_payments {
   return @{ $self->get('_items_payments') };
 }
 
-=sub _items_payments_total
+=item _items_payments_total
 
   Return a total of all records returned by _items_payments
   Results vary based on invoicing conf flags
@@ -3357,7 +3357,7 @@ sub __items_payments_make_hashref {
   return @return;
 }
 
-=sub _items_total()
+=item _items_total()
 
   Generate the line-items to be shown on the bill in the "Totals" section
 

commit 302e2522922019c8a1c6251188066ad10ae07bdc
Author: Mitch Jackson <mitch at freeside.biz>
Date:   Sat Apr 14 12:41:30 2018 -0500

    RT# 78190 Update totals for latex summary

diff --git a/conf/invoice_latexsummary b/conf/invoice_latexsummary
index bd4ea6975..52868419b 100644
--- a/conf/invoice_latexsummary
+++ b/conf/invoice_latexsummary
@@ -14,7 +14,7 @@
 \textbf{Previous Balance}&\textbf{\dollar[@-- $true_previous_balance --@]}\\
 \textbf{Payments}&\textbf{\dollar[@-- $balance_adjustments --@]}\\
 \cline{2-2}
-\textbf{Balance Outstanding}&\textbf{\dollar[@-- sprintf('%.2f', $true_previous_balance -$balance_adjustments) --@]}\\
+\textbf{Balance Outstanding}&\textbf{\dollar[@-- sprintf('%.2f', $true_previous_balance) --@]}\\
 &\\
 \hline
 &\\
@@ -33,7 +33,7 @@
 &\\
 \textbf{\underline{Invoice Summary}} & \\
 & \\
-\textbf{Previous Past Due Charges}&\textbf{\dollar[@-- sprintf('%.2f', $true_previous_balance - $balance_adjustments) --@]}\\
+\textbf{Previous Past Due Charges}&\textbf{\dollar[@-- sprintf('%.2f', $true_previous_balance) --@]}\\
 \textbf{Finance charges on overdue amount}&\textbf{\dollar[@-- $finance_amount --@]}\\
 \textbf{New Charges}&\textbf{\dollar[@-- $current_less_finance --@]}\\
 

commit 304cf07be79b45930dcd5cb49cdf24aceaa3ebd9
Author: Mitch Jackson <mitch at freeside.biz>
Date:   Sat Apr 14 12:25:26 2018 -0500

    RT# 78190 Remove debug statements

diff --git a/FS/FS/cust_bill.pm b/FS/FS/cust_bill.pm
index 38b1d5c6d..fe3867449 100644
--- a/FS/FS/cust_bill.pm
+++ b/FS/FS/cust_bill.pm
@@ -3243,7 +3243,6 @@ sub _items_payments {
 
   if ($self->conf->exists('previous_balance-payments_since')) {
     if ($template eq 'statement') {
-print "\nCASE 3\n";
       # Case 3 (see above)
       # Return payments timestamped between the previous and following bills
 
@@ -3267,7 +3266,7 @@ print "\nCASE 3\n";
     } else {
       # Case 2 (see above)
       # Return payments timestamped between this and the previous bill
-print "\nCASE 2\n";
+
       my $date_start = 0;
       my $date_end = $self->_date;
 

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_bill.pm        | 23 +++++++++++------------
 conf/invoice_latexsummary |  4 ++--
 2 files changed, 13 insertions(+), 14 deletions(-)