[freeside-commits] branch FREESIDE_4_BRANCH updated. b587f4775b0ac6eecd6bdeec921fe0bbd4e8720a

[Ivan]

The branch, FREESIDE_4_BRANCH has been updated
       via  b587f4775b0ac6eecd6bdeec921fe0bbd4e8720a (commit)
      from  6815e03a940842b56b69a4cf4d44e9804a14fbab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b587f4775b0ac6eecd6bdeec921fe0bbd4e8720a
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Mon Jan 9 18:17:29 2017 -0800

    fix "unable to transfer all services" error when changing a package before it is billed, RT#73377

diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index b491f91..48e4263 100644
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -4402,8 +4402,10 @@ sub transfer {
     $target{$pkg_svc->svcpart} = $pkg_svc->quantity * ( $dest->quantity || 1 );
   }
 
-  foreach my $cust_svc ($dest->cust_svc) {
-    $target{$cust_svc->svcpart}--;
+  unless ( $self->pkgnum == $dest->pkgnum ) {
+    foreach my $cust_svc ($dest->cust_svc) {
+      $target{$cust_svc->svcpart}--;
+    }
   }
 
   my %svcpart2svcparts = ();

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_pkg.pm |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)