[freeside-commits] branch FREESIDE_4_BRANCH updated. 248a2342f4ed3bff2b9d6111a76fad881bf56765

Ivan ivan at 420.am
Sat Feb 18 17:10:51 PST 2017


The branch, FREESIDE_4_BRANCH has been updated
       via  248a2342f4ed3bff2b9d6111a76fad881bf56765 (commit)
       via  0813051e7926734289e81efb468b62940d542627 (commit)
      from  04fb5a4901bec15d10867a39324b24c71d528cdd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 248a2342f4ed3bff2b9d6111a76fad881bf56765
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Sat Feb 18 17:10:50 2017 -0800

    19 digit visa and discover cards

diff --git a/FS/FS/cust_payby.pm b/FS/FS/cust_payby.pm
index 7e4a465..ab3c41c 100644
--- a/FS/FS/cust_payby.pm
+++ b/FS/FS/cust_payby.pm
@@ -349,7 +349,7 @@ sub check {
 
     my $payinfo = $self->payinfo;
     $payinfo =~ s/\D//g;
-    $payinfo =~ /^(\d{13,16}|\d{8,9})$/
+    $payinfo =~ /^(\d{13,19}|\d{8,9})$/
       or return gettext('invalid_card'); #. ": ". $self->payinfo;
     $payinfo = $1;
     $self->payinfo($payinfo);

commit 0813051e7926734289e81efb468b62940d542627
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Sat Feb 18 17:10:28 2017 -0800

    19 digit visa and discover cards

diff --git a/FS/FS/ClientAPI/MyAccount.pm b/FS/FS/ClientAPI/MyAccount.pm
index 4a878f8..bb629a9 100644
--- a/FS/FS/ClientAPI/MyAccount.pm
+++ b/FS/FS/ClientAPI/MyAccount.pm
@@ -1007,7 +1007,7 @@ sub validate_payment {
     }
 
     $payinfo =~ s/\D//g;
-    $payinfo =~ /^(\d{13,16}|\d{8,9})$/
+    $payinfo =~ /^(\d{13,19}|\d{8,9})$/
       or return { 'error' => gettext('invalid_card') }; # . ": ". $self->payinfo
     $payinfo = $1;
 
diff --git a/FS/FS/payinfo_Mixin.pm b/FS/FS/payinfo_Mixin.pm
index c79729a..3820d7b 100644
--- a/FS/FS/payinfo_Mixin.pm
+++ b/FS/FS/payinfo_Mixin.pm
@@ -218,7 +218,7 @@ sub payinfo_check {
       $payinfo =~ s/\D//g;
       $self->payinfo($payinfo);
       if ( $self->payinfo ) {
-        $self->payinfo =~ /^(\d{13,16}|\d{8,9})$/
+        $self->payinfo =~ /^(\d{13,19}|\d{8,9})$/
           or return "Illegal (mistyped?) credit card number (payinfo)";
         $self->payinfo($1);
         validate($self->payinfo) or return "Illegal credit card number";
diff --git a/fs_selfservice/FS-SelfService/cgi/agent.cgi b/fs_selfservice/FS-SelfService/cgi/agent.cgi
index 0af94cd..d5147d2 100755
--- a/fs_selfservice/FS-SelfService/cgi/agent.cgi
+++ b/fs_selfservice/FS-SelfService/cgi/agent.cgi
@@ -150,7 +150,7 @@ sub process_signup {
     my $payinfo = $cgi->param('payinfo');
     $payinfo =~ s/\D//g;
 
-    $payinfo =~ /^(\d{13,16}|\d{8,9})$/
+    $payinfo =~ /^(\d{13,19}|\d{8,9})$/
       or $error ||= $init_data->{msgcat}{invalid_card}; #. $self->payinfo;
     $payinfo = $1;
     validate($payinfo)
diff --git a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
index d44a379..3915dca 100755
--- a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
+++ b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
@@ -618,7 +618,7 @@ sub payment_results {
 
   my $payinfo = $cgi->param('payinfo');
   $payinfo =~ s/[^\dx]//g;
-  $payinfo =~ /^([\dx]{13,16}|[\dx]{8,9})$/
+  $payinfo =~ /^([\dx]{13,19}|[\dx]{8,9})$/
     #or $error ||= $init_data->{msgcat}{invalid_card}; #. $self->payinfo;
     or return { 'error' => "illegal card" }; #!!!
   $payinfo = $1;
diff --git a/fs_selfservice/FS-SelfService/cgi/signup.cgi b/fs_selfservice/FS-SelfService/cgi/signup.cgi
index c696276..2411c54 100755
--- a/fs_selfservice/FS-SelfService/cgi/signup.cgi
+++ b/fs_selfservice/FS-SelfService/cgi/signup.cgi
@@ -201,7 +201,7 @@ if ( $magic eq 'process' || $action eq 'process_signup' ) {
       my $payinfo = $cgi->param('payinfo');
       $payinfo =~ s/\D//g;
 
-      $payinfo =~ /^(\d{13,16}|\d{8,9})$/
+      $payinfo =~ /^(\d{13,19}|\d{8,9})$/
         or $error ||= $init_data->{msgcat}{invalid_card}; #. $self->payinfo;
       $payinfo = $1;
       validate($payinfo)
diff --git a/httemplate/misc/process/payment.cgi b/httemplate/misc/process/payment.cgi
index 1532605..6226ebd 100644
--- a/httemplate/misc/process/payment.cgi
+++ b/httemplate/misc/process/payment.cgi
@@ -129,7 +129,7 @@ if ( (my $custpaybynum = scalar($cgi->param('custpaybynum'))) > 0 ) {
     $payinfo = $cgi->param('payinfo');
 
     $payinfo =~ s/\D//g;
-    $payinfo =~ /^(\d{13,16}|\d{8,9})$/
+    $payinfo =~ /^(\d{13,19}|\d{8,9})$/
       or errorpage(gettext('invalid_card'));
     $payinfo = $1;
     validate($payinfo)
diff --git a/httemplate/search/cust_main.cgi b/httemplate/search/cust_main.cgi
index 7439efe..65b8c05 100755
--- a/httemplate/search/cust_main.cgi
+++ b/httemplate/search/cust_main.cgi
@@ -582,7 +582,7 @@ sub cardsearch {
 
   my($card)=$cgi->param('card');
   $card =~ s/\D//g;
-  $card =~ /^(\d{13,16}|\d{8,9})$/ or errorpage(emt("Illegal card number"));
+  $card =~ /^(\d{13,19}|\d{8,9})$/ or errorpage(emt("Illegal card number"));
   my($payinfo)=$1;
 
   [ qsearch('cust_main',{'payinfo'=>$payinfo, 'payby'=>'CARD'}),

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/ClientAPI/MyAccount.pm                      |    2 +-
 FS/FS/cust_payby.pm                               |    2 +-
 FS/FS/payinfo_Mixin.pm                            |    2 +-
 fs_selfservice/FS-SelfService/cgi/agent.cgi       |    2 +-
 fs_selfservice/FS-SelfService/cgi/selfservice.cgi |    2 +-
 fs_selfservice/FS-SelfService/cgi/signup.cgi      |    2 +-
 httemplate/misc/process/payment.cgi               |    2 +-
 httemplate/search/cust_main.cgi                   |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)




More information about the freeside-commits mailing list