[freeside-commits] branch master updated. 964e4fc98f070a1744fe0313f44309baa8f4fb15

[Jonathan Prykop]

The branch, master has been updated
       via  964e4fc98f070a1744fe0313f44309baa8f4fb15 (commit)
      from  1443045cf75c0bba05a753d6036327a8092bcfca (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 964e4fc98f070a1744fe0313f44309baa8f4fb15
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Tue May 3 23:17:37 2016 -0500

    RT#37632: Credit card validation [cust_pay_pending handling on error]

diff --git a/FS/FS/cust_main/Billing_Realtime.pm b/FS/FS/cust_main/Billing_Realtime.pm
index bbf86a5..54c7c5d 100644
--- a/FS/FS/cust_main/Billing_Realtime.pm
+++ b/FS/FS/cust_main/Billing_Realtime.pm
@@ -1965,6 +1965,17 @@ sub realtime_verify_bop {
 
     }
 
+  } else { # is not success
+
+    # status is 'done' not 'declined', as in _realtime_bop_result
+    $cust_pay_pending->status('done');
+    $cust_pay_pending->statustext( $transaction->error_message || 'Unknown error' );
+    # could also record failure_status here,
+    #   but it's not supported by B::OP::vSecureProcessing...
+    #   need a B::OP module with (reverse) auth only to test it with
+    my $cpp_declined_err = $cust_pay_pending->replace;
+    return $cpp_declined_err if $cpp_declined_err;
+
   }
 
   ###

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main/Billing_Realtime.pm |   11 +++++++++++
 1 file changed, 11 insertions(+)