[freeside-commits] branch FREESIDE_3_BRANCH updated. 29a7178b002a00aea85973a056cfecb0e23cb99e

[Ivan]

The branch, FREESIDE_3_BRANCH has been updated
       via  29a7178b002a00aea85973a056cfecb0e23cb99e (commit)
      from  27f686f91cbd326b2afd06d9428597c27888cd39 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 29a7178b002a00aea85973a056cfecb0e23cb99e
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Mon May 2 15:24:07 2016 -0700

    verify credit card changes via $1 auth, RT#37632

diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm
index cfcd5f4..6e66646 100644
--- a/FS/FS/cust_main.pm
+++ b/FS/FS/cust_main.pm
@@ -1538,6 +1538,11 @@ sub replace {
   {
     my $error = $self->check_payinfo_cardtype;
     return $error if $error;
+
+    if ( $conf->exists('business-onlinepayment-verification') ) {
+      $error = $self->realtime_verify_bop({ 'method'=>'CC' });
+      return $error if $error;
+    }
   }
 
   return "Invoicing locale is required"
diff --git a/FS/FS/cust_main/Billing_Realtime.pm b/FS/FS/cust_main/Billing_Realtime.pm
index 0a61ad1..90fda5e 100644
--- a/FS/FS/cust_main/Billing_Realtime.pm
+++ b/FS/FS/cust_main/Billing_Realtime.pm
@@ -1758,7 +1758,7 @@ sub realtime_verify_bop {
 
   my $ban = FS::banned_pay->ban_search(
     'payby'   => $bop_method2payby{'CC'},
-    'payinfo' => $options{payinfo},
+    'payinfo' => $options{payinfo} || $self->payinfo,
   );
   return "Banned credit card" if $ban && $ban->bantype ne 'warn';
 
@@ -1787,7 +1787,7 @@ sub realtime_verify_bop {
 
     if ( $options{method} eq 'CC' ) {
 
-      $content{card_number} = $options{payinfo};
+      $content{card_number} = $options{payinfo} || $self->payinfo;
       $paydate = exists($options{'paydate'})
                       ? $options{'paydate'}
                       : $self->paydate;
@@ -1860,8 +1860,8 @@ sub realtime_verify_bop {
     'paid'              => '1.00',
     '_date'             => '',
     'payby'             => $bop_method2payby{'CC'},
-    'payinfo'           => $options{payinfo},
-    'paymask'           => $options{paymask},
+    'payinfo'           => $options{payinfo} || $self->payinfo,
+    'paymask'           => $options{paymask} || $self->paymask,
     'paydate'           => $paydate,
     #'recurring_billing' => $content{recurring_billing},
     'pkgnum'            => $options{'pkgnum'},

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main.pm                  |    5 +++++
 FS/FS/cust_main/Billing_Realtime.pm |    8 ++++----
 2 files changed, 9 insertions(+), 4 deletions(-)