[freeside-commits] branch FREESIDE_4_BRANCH updated. 236d885264964c81cb293791a3458f8823746704

[Jonathan Prykop]

The branch, FREESIDE_4_BRANCH has been updated
       via  236d885264964c81cb293791a3458f8823746704 (commit)
      from  c8ad68aada943ca7d468ed42695f043fa0d0f06f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 236d885264964c81cb293791a3458f8823746704
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Mon Jun 6 23:03:04 2016 -0500

    RT#71011: Prospect quotation error v4+

diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm
index 2c092ee..68ddca2 100644
--- a/FS/FS/cust_main.pm
+++ b/FS/FS/cust_main.pm
@@ -532,6 +532,7 @@ sub insert {
     foreach my $prospect_contact ( $prospect_main->prospect_contact ) {
       my $cust_contact = new FS::cust_contact {
         'custnum' => $self->custnum,
+        'invoice_dest' => 'Y', # invoice_dest currently not set for prospect contacts
         map { $_ => $prospect_contact->$_() } qw( contactnum classnum comment )
       };
       my $error =  $cust_contact->insert
diff --git a/FS/FS/prospect_main.pm b/FS/FS/prospect_main.pm
index f600b23..9472996 100644
--- a/FS/FS/prospect_main.pm
+++ b/FS/FS/prospect_main.pm
@@ -352,9 +352,6 @@ sub convert_cust_main {
 
   my @contact = map $_->contact, $self->prospect_contact;
 
-  #XXX define one contact type as "billing", then we could pick just that one
-  my @invoicing_list = map $_->emailaddress, map $_->contact_email, @contact;
-
   #XXX i'm not compatible with cust_main-require_phone (which is kind of a
   # pre-contact thing anyway)
 
@@ -379,7 +376,7 @@ sub convert_cust_main {
   #$cust_main->payby('BILL');
   #$cust_main->paydate('12/2037');
 
-  $cust_main->insert( {}, \@invoicing_list,
+  $cust_main->insert( {},
     'prospectnum' => $self->prospectnum,
   )
     or $cust_main;

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main.pm     |    1 +
 FS/FS/prospect_main.pm |    5 +----
 2 files changed, 2 insertions(+), 4 deletions(-)