[freeside-commits] branch FREESIDE_3_BRANCH updated. 64427efc6ccc314e525b310c02b39a6f776b99f4

[Mark Wells]

The branch, FREESIDE_3_BRANCH has been updated
       via  64427efc6ccc314e525b310c02b39a6f776b99f4 (commit)
      from  79129a414248ce263a8810ba7966bfdc82680674 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 64427efc6ccc314e525b310c02b39a6f776b99f4
Author: Mark Wells <mark at freeside.biz>
Date:   Fri Jun 3 17:45:04 2016 -0700

    calculate unitrecur on sql_external packages with quantity details, #40558

diff --git a/FS/FS/cust_main/Billing.pm b/FS/FS/cust_main/Billing.pm
index 7752956..7cb3837 100644
--- a/FS/FS/cust_main/Billing.pm
+++ b/FS/FS/cust_main/Billing.pm
@@ -1361,6 +1361,7 @@ sub _make_lines {
 
     if ( $param{'override_quantity'} ) {
       $override_quantity = $param{'override_quantity'};
+      $unitrecur = $recur / $override_quantity;
     }
 
     if ( $increment_next_bill ) {
diff --git a/FS/FS/part_pkg/sql_external.pm b/FS/FS/part_pkg/sql_external.pm
index 48d89a0..38bd8d7 100644
--- a/FS/FS/part_pkg/sql_external.pm
+++ b/FS/FS/part_pkg/sql_external.pm
@@ -96,8 +96,7 @@ sub calc_recur {
             die "sql_external query returned non-numeric amount: $row->{amount}";
           }
         }
-        if (exists $row->{quantity}) {
-          $quantity ||= 0;
+        if (defined $row->{quantity}) {
           if ( $row->{quantity} eq '' ) {
             # treat as zero
           } elsif ( $row->{quantity} =~ /^\d+$/ ) {

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main/Billing.pm     |    1 +
 FS/FS/part_pkg/sql_external.pm |    3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)