[freeside-commits] branch FREESIDE_4_BRANCH updated. 75944a8bdfc02166b16f2f6c03adcff75bf6cc3b

[Jonathan Prykop]

The branch, FREESIDE_4_BRANCH has been updated
       via  75944a8bdfc02166b16f2f6c03adcff75bf6cc3b (commit)
       via  74774909afba9aca91bb074d1fbf687d9bed1688 (commit)
      from  e32f1ceeb6f267ab6d3279bf350d192d4bf1a72e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75944a8bdfc02166b16f2f6c03adcff75bf6cc3b
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Tue Jan 5 23:29:42 2016 -0600

    RT#38671: Do not include charges and credits from failed signup processing [v4 only, default reason type]

diff --git a/FS/FS/cust_bill.pm b/FS/FS/cust_bill.pm
index 14b9f79..8c1f75c 100644
--- a/FS/FS/cust_bill.pm
+++ b/FS/FS/cust_bill.pm
@@ -229,7 +229,7 @@ sub void {
   unless (ref($reason) || !$reason) {
     $reason = FS::reason->new_or_existing(
       'class'  => 'I',
-      'type'   => 'Void invoice',
+      'type'   => 'Invoice void',
       'reason' => $reason
     );
   }
diff --git a/FS/FS/cust_bill_pkg.pm b/FS/FS/cust_bill_pkg.pm
index d3290bf..e7860e0 100644
--- a/FS/FS/cust_bill_pkg.pm
+++ b/FS/FS/cust_bill_pkg.pm
@@ -338,7 +338,7 @@ sub void {
   unless (ref($reason) || !$reason) {
     $reason = FS::reason->new_or_existing(
       'class'  => 'I',
-      'type'   => 'Void invoice',
+      'type'   => 'Invoice void',
       'reason' => $reason
     );
   }

commit 74774909afba9aca91bb074d1fbf687d9bed1688
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Tue Jan 5 23:08:57 2016 -0600

    RT#38671: Do not include charges and credits from failed signup processing [v4 only, modern reason handling]

diff --git a/FS/FS/cust_bill.pm b/FS/FS/cust_bill.pm
index ccf141b..14b9f79 100644
--- a/FS/FS/cust_bill.pm
+++ b/FS/FS/cust_bill.pm
@@ -228,7 +228,7 @@ sub void {
 
   unless (ref($reason) || !$reason) {
     $reason = FS::reason->new_or_existing(
-      'class'  => 'X',
+      'class'  => 'I',
       'type'   => 'Void invoice',
       'reason' => $reason
     );
diff --git a/FS/FS/cust_bill_pkg.pm b/FS/FS/cust_bill_pkg.pm
index aea776a..d3290bf 100644
--- a/FS/FS/cust_bill_pkg.pm
+++ b/FS/FS/cust_bill_pkg.pm
@@ -337,7 +337,7 @@ sub void {
 
   unless (ref($reason) || !$reason) {
     $reason = FS::reason->new_or_existing(
-      'class'  => 'X',
+      'class'  => 'I',
       'type'   => 'Void invoice',
       'reason' => $reason
     );

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_bill.pm     |    4 ++--
 FS/FS/cust_bill_pkg.pm |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)