[freeside-commits] branch FREESIDE_3_BRANCH updated. 99e45c99df978410140c0e14f17820d57f9e6b54

[Ivan]

The branch, FREESIDE_3_BRANCH has been updated
       via  99e45c99df978410140c0e14f17820d57f9e6b54 (commit)
      from  3d7fbe317c6a3e4b130533ff0465ba8b4323204c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 99e45c99df978410140c0e14f17820d57f9e6b54
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Tue Dec 13 12:39:50 2016 -0800

    Revert "Format email addresses w/Email::Address instead of ad-hoc, fixes issues emailing companies with commas, RT#73241"
    
    This reverts commit bf6d06efe903dfd4c112fb9eccb98344841b729c.

diff --git a/FS/FS/cust_main.pm b/FS/FS/cust_main.pm
index 0165bc4..7e1a25d 100644
--- a/FS/FS/cust_main.pm
+++ b/FS/FS/cust_main.pm
@@ -32,7 +32,6 @@ use Digest::MD5 qw(md5_base64);
 use Date::Format;
 #use Date::Manip;
 use File::Temp; #qw( tempfile );
-use Email::Address;
 use Business::CreditCard 0.28;
 use FS::UID qw( getotaker dbh driver_name );
 use FS::Record qw( qsearchs qsearch dbdef regexp_sql );
@@ -3572,17 +3571,15 @@ sub contact_list_email {
         # unlike on 4.x, we have a separate list of invoice email
         # destinations.
         # make sure they're not redundant with contact emails
-        $emails{ $contact_email->emailaddress } =
-          Email::Address->new( $contact->firstlast,
-                               $contact_email->emailaddress
-                             )->format;
+        my $dest = $contact->firstlast . ' <' . $contact_email->emailaddress . '>';
+        $emails{ $contact_email->emailaddress } = $dest;
       }
     }
   }
   if ( $and_invoice ) {
     foreach my $email ($self->invoicing_list_emailonly) {
-      $emails{ $email } ||=
-        Email::Address->new( $self->name_short, $email )->format;
+      my $dest = $self->name_short . ' <' . $email . '>';
+      $emails{ $email } ||= $dest;
     }
   }
   values %emails;

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_main.pm |   11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)