[freeside-commits] branch master updated. 8eb6542c022ac84b125416f3fb0828b278ba600a
Jonathan Prykop
jonathan at 420.am
Mon Apr 18 11:28:19 PDT 2016
The branch, master has been updated
via 8eb6542c022ac84b125416f3fb0828b278ba600a (commit)
from 0be54958813c9a4a5e24e32707b92e49881c7c0a (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 8eb6542c022ac84b125416f3fb0828b278ba600a
Author: Jonathan Prykop <jonathan at freeside.biz>
Date: Mon Apr 18 13:26:59 2016 -0500
Revert "RT#41671 Fix double click prevention for all legacy buttons [renamed all from submit to submitButton]"
This reverts commit d65927fb45aa1c47d7f593db0142d14799b0fabf.
diff --git a/httemplate/browse/addr_block.cgi b/httemplate/browse/addr_block.cgi
index 536a4f7..ba40bfd 100644
--- a/httemplate/browse/addr_block.cgi
+++ b/httemplate/browse/addr_block.cgi
@@ -111,7 +111,7 @@ $html_foot .= include( '/elements/select-agent.html',
'agent_null_right' => 'Broadband global configuration',
);
$html_foot .= qq(
- <INPUT TYPE="submit" NAME="submitButton" VALUE="Add">
+ <INPUT TYPE="submit" NAME="submit" VALUE="Add">
</FORM>
);
diff --git a/httemplate/edit/cust_main_attach.cgi b/httemplate/edit/cust_main_attach.cgi
index ba40b30..0880c76 100755
--- a/httemplate/edit/cust_main_attach.cgi
+++ b/httemplate/edit/cust_main_attach.cgi
@@ -31,7 +31,7 @@
</TABLE>
<BR>
% if(! $disabled) {
-<INPUT TYPE="submit" NAME="submitButton"
+<INPUT TYPE="submit" NAME="submit"
VALUE="<% $attachnum ? emt("Apply changes") : emt("Upload File") %>">
% }
% if(defined $attach and $curuser->access_right('Delete attachment')) {
diff --git a/httemplate/edit/cust_pkg_detail.html b/httemplate/edit/cust_pkg_detail.html
index 37a8013..a1a6db6 100644
--- a/httemplate/edit/cust_pkg_detail.html
+++ b/httemplate/edit/cust_pkg_detail.html
@@ -43,7 +43,7 @@
</TABLE>
<BR>
-<INPUT TYPE="submit" ID="submit" NAME="submitButton" VALUE="<% $title %>">
+<INPUT TYPE="submit" ID="submit" NAME="submit" VALUE="<% $title %>">
</FORM>
diff --git a/httemplate/edit/cust_pkg_discount.html b/httemplate/edit/cust_pkg_discount.html
index 5aece57..e1e3dae 100755
--- a/httemplate/edit/cust_pkg_discount.html
+++ b/httemplate/edit/cust_pkg_discount.html
@@ -23,7 +23,7 @@
</TABLE>
<BR>
-<INPUT NAME="submitButton" TYPE="submit" VALUE="Discount package">
+<INPUT NAME="submit" TYPE="submit" VALUE="Discount package">
</FORM>
</BODY>
diff --git a/httemplate/edit/cust_pkg_quantity.html b/httemplate/edit/cust_pkg_quantity.html
index eadd1b5..ec47ed6 100755
--- a/httemplate/edit/cust_pkg_quantity.html
+++ b/httemplate/edit/cust_pkg_quantity.html
@@ -21,7 +21,7 @@
</TABLE>
<BR>
-<INPUT NAME="submitButton" TYPE="submit" VALUE="Change">
+<INPUT NAME="submit" TYPE="submit" VALUE="Change">
</FORM>
</BODY>
diff --git a/httemplate/edit/cust_pkg_salesnum.html b/httemplate/edit/cust_pkg_salesnum.html
index da6c0e8..dba2a90 100755
--- a/httemplate/edit/cust_pkg_salesnum.html
+++ b/httemplate/edit/cust_pkg_salesnum.html
@@ -21,7 +21,7 @@
</TABLE>
<BR>
-<INPUT NAME="submitButton" TYPE="submit" VALUE="Change">
+<INPUT NAME="submit" TYPE="submit" VALUE="Change">
</FORM>
</BODY>
diff --git a/httemplate/edit/elements/ApplicationCommon.html b/httemplate/edit/elements/ApplicationCommon.html
index 9c068c1..a531eaa 100644
--- a/httemplate/edit/elements/ApplicationCommon.html
+++ b/httemplate/edit/elements/ApplicationCommon.html
@@ -103,7 +103,7 @@ function changed(what) {
dst = what.options[what.selectedIndex].value;
if ( dst == '' ) {
- what.form.submitButton.disabled=true;
+ what.form.submit.disabled=true;
%if ($use_sub_dst_thing && $src_pkey eq 'crednum') {
what.form.tax_button.disabled=true;
what.form.clear_button.disabled=true;
@@ -111,7 +111,7 @@ function changed(what) {
return true;
}
- what.form.submitButton.disabled=false;
+ what.form.submit.disabled=false;
%if ($use_sub_dst_thing && $src_pkey eq 'crednum') {
what.form.tax_button.disabled=false;
what.form.clear_button.disabled=false;
@@ -373,7 +373,7 @@ function src_amount_changed () {
<BR>
<CENTER><INPUT TYPE="submit"
VALUE="Apply"
- NAME="submitButton"
+ NAME="submit"
ID="submit"
% if ($use_sub_dst_thing && $can_change_credit) {
onClick="src_amount_changed()"
diff --git a/httemplate/edit/elements/part_svc_column.html b/httemplate/edit/elements/part_svc_column.html
index 1944e5f..bc679e5 100644
--- a/httemplate/edit/elements/part_svc_column.html
+++ b/httemplate/edit/elements/part_svc_column.html
@@ -273,7 +273,7 @@ my %communigate_fields = (
&>
% $svcpart = '' if $opt{clone};
<BR>
-<INPUT NAME="submitButton"
+<INPUT NAME="submit"
TYPE="button"
VALUE="<% emt($svcpart ? 'Apply changes' : 'Add service') %>"
onclick="fixup_submit('<%$svcdb%>')"
diff --git a/httemplate/edit/invoice_logo.html b/httemplate/edit/invoice_logo.html
index f0064e2..e1c6149 100644
--- a/httemplate/edit/invoice_logo.html
+++ b/httemplate/edit/invoice_logo.html
@@ -54,7 +54,7 @@
% if ( $mode eq 'upload' ) {
Upload new logo (.<%uc($type)%> format): <INPUT TYPE="file" NAME="new_logo">
- <BR><INPUT TYPE="submit" NAME="submitButton" VALUE="Upload">
+ <BR><INPUT TYPE="submit" NAME="submit" VALUE="Upload">
% } elsif ( $mode eq 'preview' ) {
@@ -71,7 +71,7 @@
% if ( $mode eq 'preview' ) {
<BR>
- <INPUT TYPE="submit" NAME="submitButton" VALUE="Change logo">
+ <INPUT TYPE="submit" NAME="submit" VALUE="Change logo">
% }
</FORM>
diff --git a/httemplate/edit/part_svc.cgi b/httemplate/edit/part_svc.cgi
index fa5a81a..a07fc60 100755
--- a/httemplate/edit/part_svc.cgi
+++ b/httemplate/edit/part_svc.cgi
@@ -37,7 +37,7 @@
</STYLE>
<SCRIPT TYPE="text/javascript">
function fixup_submit(layer) {
- document.forms[layer].submitButton.disabled = true;
+ document.forms[layer].submit.disabled = true;
fixup(document.forms[layer]);
window[layer+'process'].call();
}
diff --git a/httemplate/edit/prospect_main-upload.html b/httemplate/edit/prospect_main-upload.html
index 733e5c2..24b1caa 100644
--- a/httemplate/edit/prospect_main-upload.html
+++ b/httemplate/edit/prospect_main-upload.html
@@ -2,6 +2,6 @@
<FORM ACTION="prospect_main-ocr.html" METHOD="POST" ENCTYPE="multipart/form-data">
<INPUT TYPE="file" NAME="card">
- <BR><INPUT TYPE="submit" NAME="submitButton" VALUE="Upload">
+ <BR><INPUT TYPE="submit" NAME="submit" VALUE="Upload">
<% include('/elements/footer.html') %>
diff --git a/httemplate/edit/quotation_pkg_detail.html b/httemplate/edit/quotation_pkg_detail.html
index 10d5af0..036bffd 100644
--- a/httemplate/edit/quotation_pkg_detail.html
+++ b/httemplate/edit/quotation_pkg_detail.html
@@ -39,7 +39,7 @@
</TABLE>
<BR>
-<INPUT TYPE="submit" ID="submit" NAME="submitButton" VALUE="<% $title %>">
+<INPUT TYPE="submit" ID="submit" NAME="submit" VALUE="<% $title %>">
</FORM>
diff --git a/httemplate/elements/progress-init.html b/httemplate/elements/progress-init.html
index ba2e6be..e38dde6 100644
--- a/httemplate/elements/progress-init.html
+++ b/httemplate/elements/progress-init.html
@@ -92,8 +92,8 @@ function <%$key%>process () {
//alert('<%$key%>process for form <%$formname%>');
- if ( document.<%$formname%>.submitButton.disabled == false ) {
- document.<%$formname%>.submitButton.disabled=true;
+ if ( document.<%$formname%>.submit.disabled == false ) {
+ document.<%$formname%>.submit.disabled=true;
}
overlib( 'Submitting job to server...', WIDTH, 444, HEIGHT, 168, CAPTION, 'Please wait...', STICKY, AUTOSTATUSCAP, CLOSETEXT, '', CLOSECLICK, MIDX, 0, MIDY, 0 );
diff --git a/httemplate/misc/cancel_cust.html b/httemplate/misc/cancel_cust.html
index d3da6fe..8536702 100644
--- a/httemplate/misc/cancel_cust.html
+++ b/httemplate/misc/cancel_cust.html
@@ -55,7 +55,7 @@ toggle(false);
<BR>
<P ALIGN="CENTER">
-<INPUT TYPE="submit" NAME="submitButton" ID="confirm_cancel_cust_button" VALUE="<% mt('Cancel customer') |h %>" DISABLED>
+<INPUT TYPE="submit" NAME="submit" ID="confirm_cancel_cust_button" VALUE="<% mt('Cancel customer') |h %>" DISABLED>
<INPUT TYPE="BUTTON" VALUE="<% mt("Don't cancel") |h %>" onClick="parent.cClick();">
diff --git a/httemplate/misc/cancel_pkg.html b/httemplate/misc/cancel_pkg.html
index bee206a..c80b2b2 100755
--- a/httemplate/misc/cancel_pkg.html
+++ b/httemplate/misc/cancel_pkg.html
@@ -91,7 +91,7 @@
</TABLE>
<BR>
-<INPUT TYPE="submit" NAME="submitButton" ID="confirm_cancel_pkg_button"
+<INPUT TYPE="submit" NAME="submit" ID="confirm_cancel_pkg_button"
VALUE="<% mt($submit) |h %>"
<% $method !~ /^(resume|uncancel)$/ ? 'DISABLED' : '' %>>
diff --git a/httemplate/misc/change_pkg_start.html b/httemplate/misc/change_pkg_start.html
index 25a3c24..5a890c8 100755
--- a/httemplate/misc/change_pkg_start.html
+++ b/httemplate/misc/change_pkg_start.html
@@ -47,7 +47,7 @@
&>
</LI>
</UL>
-<INPUT TYPE="submit" NAME="submitButton" VALUE="<% emt('Set start date') %>">
+<INPUT TYPE="submit" NAME="submit" VALUE="<% emt('Set start date') %>">
</FORM>
</BODY>
diff --git a/httemplate/misc/cust_bill-promised_date.html b/httemplate/misc/cust_bill-promised_date.html
index 0e417a2..7b7b960 100644
--- a/httemplate/misc/cust_bill-promised_date.html
+++ b/httemplate/misc/cust_bill-promised_date.html
@@ -9,7 +9,7 @@
emt('Promised date'),
&>
</TABLE>
-<INPUT TYPE="submit" NAME="submitButton" VALUE="<% emt('Set date') %>">
+<INPUT TYPE="submit" NAME="submit" VALUE="<% emt('Set date') %>">
</FORM>
<& /elements/footer.html &>
<%init>
diff --git a/httemplate/misc/cust_main_note-import.cgi b/httemplate/misc/cust_main_note-import.cgi
index 12d6c36..2e7dc8b 100644
--- a/httemplate/misc/cust_main_note-import.cgi
+++ b/httemplate/misc/cust_main_note-import.cgi
@@ -190,7 +190,7 @@
% $row++;
% }
</TABLE>
- <INPUT TYPE="submit" NAME="submitButton" ID="importsubmit" VALUE="Import notes">
+ <INPUT TYPE="submit" NAME="submit" ID="importsubmit" VALUE="Import notes">
<INPUT TYPE="checkbox" NAME="preview" onchange="previewChanged(this);">
Preview mode
% } else {
diff --git a/httemplate/misc/delay_susp_pkg.html b/httemplate/misc/delay_susp_pkg.html
index 6167509..02f8824 100755
--- a/httemplate/misc/delay_susp_pkg.html
+++ b/httemplate/misc/delay_susp_pkg.html
@@ -36,7 +36,7 @@
</TABLE>
<BR>
-<INPUT TYPE="submit" NAME="submitButton" VALUE="<% $submit %>">
+<INPUT TYPE="submit" NAME="submit" VALUE="<% $submit %>">
</FORM>
</BODY>
diff --git a/httemplate/misc/nms-add_iface.html b/httemplate/misc/nms-add_iface.html
index 74e1d83..11456f2 100644
--- a/httemplate/misc/nms-add_iface.html
+++ b/httemplate/misc/nms-add_iface.html
@@ -10,7 +10,7 @@ Torrus Service Id
)
%>
<BR>
-<INPUT TYPE="submit" NAME="submitButton" ID="submit_nms-add_iface" VALUE="Add Interface">
+<INPUT TYPE="submit" NAME="submit" ID="submit_nms-add_iface" VALUE="Add Interface">
</FORM>
<%init>
diff --git a/httemplate/misc/nms-add_router.html b/httemplate/misc/nms-add_router.html
index 3a8a150..c32ceb8 100644
--- a/httemplate/misc/nms-add_router.html
+++ b/httemplate/misc/nms-add_router.html
@@ -14,7 +14,7 @@ SNMP Community String (optional)
%>
<BR>
<BR>
-<INPUT TYPE="submit" NAME="submitButton" ID="submit_nms-add_router" VALUE="Add Router">
+<INPUT TYPE="submit" NAME="submit" ID="submit_nms-add_router" VALUE="Add Router">
</FORM>
</BODY></HTML>
<%init>
diff --git a/httemplate/misc/progress-popup.html b/httemplate/misc/progress-popup.html
index 66fe9a8..8e2d676 100644
--- a/httemplate/misc/progress-popup.html
+++ b/httemplate/misc/progress-popup.html
@@ -58,8 +58,8 @@ function updateStatus( status_statustext ) {
document.getElementById("progress_jobnum").innerHTML = '';
% unless ( $url ) {
- if ( parent.document.<%$formname%>.submitButton.disabled == true ) {
- parent.document.<%$formname%>.submitButton.disabled=false;
+ if ( parent.document.<%$formname%>.submit.disabled == true ) {
+ parent.document.<%$formname%>.submit.disabled=false;
}
% }
@@ -93,8 +93,8 @@ function updateStatus( status_statustext ) {
document.getElementById("progress_bar").innerHTML = '';
document.getElementById("progress_percent").innerHTML = '<INPUT TYPE="button" VALUE="OK" onClick="<% $onClick %>">';
document.getElementById("progress_jobnum").innerHTML = '';
- if ( parent.document.<%$formname%>.submitButton.disabled == true ) {
- parent.document.<%$formname%>.submitButton.disabled=false;
+ if ( parent.document.<%$formname%>.submit.disabled == true ) {
+ parent.document.<%$formname%>.submit.disabled=false;
}
} else {
alert('XXX unknown status returned from server: ' + status);
diff --git a/httemplate/misc/recharge_svc.html b/httemplate/misc/recharge_svc.html
index 593c0fa..a1732fc 100755
--- a/httemplate/misc/recharge_svc.html
+++ b/httemplate/misc/recharge_svc.html
@@ -37,7 +37,7 @@
</TABLE>
<BR>
-<INPUT TYPE="submit" NAME="submitButton" VALUE="Recharge">
+<INPUT TYPE="submit" NAME="submit" VALUE="Recharge">
</FORM>
diff --git a/httemplate/misc/suspend_cust.html b/httemplate/misc/suspend_cust.html
index 7d2c5f6..83d9743 100644
--- a/httemplate/misc/suspend_cust.html
+++ b/httemplate/misc/suspend_cust.html
@@ -47,7 +47,7 @@ toggle(false);
<BR>
<P ALIGN="CENTER">
-<INPUT TYPE="submit" NAME="submitButton" ID="confirm_suspend_cust_button" VALUE="<% mt('Suspend customer') |h %>" DISABLED>
+<INPUT TYPE="submit" NAME="submit" ID="confirm_suspend_cust_button" VALUE="<% mt('Suspend customer') |h %>" DISABLED>
<INPUT TYPE="BUTTON" VALUE="<% mt("Don't suspend") |h %>" onClick="parent.cClick();">
diff --git a/httemplate/misc/timeworked.html b/httemplate/misc/timeworked.html
index b24e313..a0cf743 100755
--- a/httemplate/misc/timeworked.html
+++ b/httemplate/misc/timeworked.html
@@ -86,7 +86,7 @@
<INPUT TYPE="hidden" NAME="end" VALUE="<% $cgi->param('end') |h %>">
<INPUT TYPE="hidden" NAME="category" VALUE="<% $cgi->param('category') |h %>">
-<INPUT TYPE="submit" NAME="submitButton" VALUE="<% $title %>">
+<INPUT TYPE="submit" NAME="submit" VALUE="<% $title %>">
</FORM>
<% include('/elements/footer.html') %>
diff --git a/httemplate/misc/unhold_pkg.html b/httemplate/misc/unhold_pkg.html
index 40b55c6..0c110b4 100755
--- a/httemplate/misc/unhold_pkg.html
+++ b/httemplate/misc/unhold_pkg.html
@@ -47,7 +47,7 @@
&>
</LI>
</UL>
-<INPUT TYPE="submit" NAME="submitButton" VALUE="<% emt('Start billing') %>">
+<INPUT TYPE="submit" NAME="submit" VALUE="<% emt('Start billing') %>">
</FORM>
</BODY>
diff --git a/httemplate/misc/unsuspend_cust.html b/httemplate/misc/unsuspend_cust.html
index 6c2c707..4555a58 100644
--- a/httemplate/misc/unsuspend_cust.html
+++ b/httemplate/misc/unsuspend_cust.html
@@ -52,7 +52,7 @@ toggle(false);
<BR>
<P ALIGN="CENTER">
-<INPUT TYPE="submit" NAME="submitButton" ID="confirm_unsuspend_cust_button" VALUE="<% mt('Unsuspend customer') |h %>">
+<INPUT TYPE="submit" NAME="submit" ID="confirm_unsuspend_cust_button" VALUE="<% mt('Unsuspend customer') |h %>">
<INPUT TYPE="BUTTON" VALUE="<% mt("Don't unsuspend") |h %>" onClick="parent.cClick();">
diff --git a/httemplate/search/cust_pkg_svc.html b/httemplate/search/cust_pkg_svc.html
index 8a3c870..cdc7035 100644
--- a/httemplate/search/cust_pkg_svc.html
+++ b/httemplate/search/cust_pkg_svc.html
@@ -109,7 +109,7 @@ my $areboxes = 0;
my $html_foot = qq!
<BR>
-<INPUT TYPE="submit" NAME="submitButton" VALUE="Unprovision selected">
+<INPUT TYPE="submit" NAME="submit" VALUE="Unprovision selected">
<INPUT TYPE="hidden" NAME="pkgnum" VALUE=$pkgnum>
<INPUT TYPE="hidden" NAME="svcpart" VALUE=$svcpart>
</FORM>!;
diff --git a/httemplate/view/svc_acct/change_svc.html b/httemplate/view/svc_acct/change_svc.html
index 0456214..ed4aadd 100644
--- a/httemplate/view/svc_acct/change_svc.html
+++ b/httemplate/view/svc_acct/change_svc.html
@@ -9,7 +9,7 @@
% }
</SELECT>
- <INPUT NAME="submitButton" TYPE="submit" VALUE="<% mt('Change') |h %>" disabled>
+ <INPUT NAME="submit" TYPE="submit" VALUE="<% mt('Change') |h %>" disabled>
% }
diff --git a/httemplate/view/svc_acct/change_svc_form.html b/httemplate/view/svc_acct/change_svc_form.html
index 7e2ef02..4f10922 100644
--- a/httemplate/view/svc_acct/change_svc_form.html
+++ b/httemplate/view/svc_acct/change_svc_form.html
@@ -2,9 +2,9 @@
<SCRIPT TYPE="text/javascript">
function enable_change () {
if ( document.OneTrueForm.svcpart.selectedIndex > 1 ) {
- document.OneTrueForm.submitButton.disabled = false;
+ document.OneTrueForm.submit.disabled = false;
} else {
- document.OneTrueForm.submitButton.disabled = true;
+ document.OneTrueForm.submit.disabled = true;
}
}
</SCRIPT>
-----------------------------------------------------------------------
Summary of changes:
httemplate/browse/addr_block.cgi | 2 +-
httemplate/edit/cust_main_attach.cgi | 2 +-
httemplate/edit/cust_pkg_detail.html | 2 +-
httemplate/edit/cust_pkg_discount.html | 2 +-
httemplate/edit/cust_pkg_quantity.html | 2 +-
httemplate/edit/cust_pkg_salesnum.html | 2 +-
httemplate/edit/elements/ApplicationCommon.html | 6 +++---
httemplate/edit/elements/part_svc_column.html | 2 +-
httemplate/edit/invoice_logo.html | 4 ++--
httemplate/edit/part_svc.cgi | 2 +-
httemplate/edit/prospect_main-upload.html | 2 +-
httemplate/edit/quotation_pkg_detail.html | 2 +-
httemplate/elements/progress-init.html | 4 ++--
httemplate/misc/cancel_cust.html | 2 +-
httemplate/misc/cancel_pkg.html | 2 +-
httemplate/misc/change_pkg_start.html | 2 +-
httemplate/misc/cust_bill-promised_date.html | 2 +-
httemplate/misc/cust_main_note-import.cgi | 2 +-
httemplate/misc/delay_susp_pkg.html | 2 +-
httemplate/misc/nms-add_iface.html | 2 +-
httemplate/misc/nms-add_router.html | 2 +-
httemplate/misc/progress-popup.html | 8 ++++----
httemplate/misc/recharge_svc.html | 2 +-
httemplate/misc/suspend_cust.html | 2 +-
httemplate/misc/timeworked.html | 2 +-
httemplate/misc/unhold_pkg.html | 2 +-
httemplate/misc/unsuspend_cust.html | 2 +-
httemplate/search/cust_pkg_svc.html | 2 +-
httemplate/view/svc_acct/change_svc.html | 2 +-
httemplate/view/svc_acct/change_svc_form.html | 4 ++--
30 files changed, 38 insertions(+), 38 deletions(-)
More information about the freeside-commits
mailing list