[freeside-commits] branch master updated. 39886919a332d3cd4b8a3d9ad9b7a9f14d0576a0

Jonathan Prykop jonathan at 420.am
Tue Oct 27 17:09:29 PDT 2015


The branch, master has been updated
       via  39886919a332d3cd4b8a3d9ad9b7a9f14d0576a0 (commit)
      from  bc678cfbd4d28955fbaed101ee647714a8f2c469 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 39886919a332d3cd4b8a3d9ad9b7a9f14d0576a0
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Tue Oct 27 19:09:07 2015 -0500

    RT#38671: Do not include charges and credits from failed signup processing [deprecated signup_credit_type]

diff --git a/FS/FS/Conf.pm b/FS/FS/Conf.pm
index 594c0e0..990f2a3 100644
--- a/FS/FS/Conf.pm
+++ b/FS/FS/Conf.pm
@@ -4176,9 +4176,10 @@ and customer address. Include units.',
     reason_type_options('R'),
   },
 
+  # was only used to negate invoices during signup when card was declined, now we just void
   {
     'key'         => 'signup_credit_type',
-    'section'     => 'billing', #self-service?
+    'section'     => 'deprecated', #self-service?
     'description' => 'The group to use for new, automatically generated credit reasons resulting from signup and self-service declines.',
     reason_type_options('R'),
   },
diff --git a/FS/FS/cust_credit.pm b/FS/FS/cust_credit.pm
index 31adebe..2f2338e 100644
--- a/FS/FS/cust_credit.pm
+++ b/FS/FS/cust_credit.pm
@@ -40,7 +40,6 @@ $FS::UID::callback{'FS::cust_credit'} = sub {
 
 our %reasontype_map = ( 'referral_credit_type' => 'Referral Credit',
                         'cancel_credit_type'   => 'Cancellation Credit',
-                        'signup_credit_type'   => 'Self-Service Credit',
                       );
 
 =head1 NAME

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/Conf.pm        |    3 ++-
 FS/FS/cust_credit.pm |    1 -
 2 files changed, 2 insertions(+), 2 deletions(-)




More information about the freeside-commits mailing list