[freeside-commits] branch FREESIDE_3_BRANCH updated. a5a3bd7c762a49add6bcb2cd10c44d9c26a8df88

[Jonathan Prykop]

The branch, FREESIDE_3_BRANCH has been updated
       via  a5a3bd7c762a49add6bcb2cd10c44d9c26a8df88 (commit)
      from  5e6b981ccafac97a17d64924ef770c471ca28ab0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a5a3bd7c762a49add6bcb2cd10c44d9c26a8df88
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Mon Oct 5 21:52:43 2015 -0500

    RT37465: RBC PAD error when calculating totals [W status is now approved]

diff --git a/FS/FS/pay_batch/RBC.pm b/FS/FS/pay_batch/RBC.pm
index 644c73c..b013678 100644
--- a/FS/FS/pay_batch/RBC.pm
+++ b/FS/FS/pay_batch/RBC.pm
@@ -66,7 +66,7 @@ $name = 'RBC';
   },
   'approved'    => sub { 
       my $hash = shift;
-      $hash->{'status'} eq ' '
+      ($hash->{'status'} eq ' ') || ($hash->{'status'} eq 'W');
   },
   'declined'    => sub {
       my $hash = shift;
@@ -127,12 +127,6 @@ $name = 'RBC';
           if $hash->{'status'} eq ' '; #false laziness with 'approved' above
         return 1;
       }
-      #skipping W for now (maybe it should be declined?)
-      if ($hash->{'status'} eq 'W') {
-        #file counts this as part of total, but we skip
-        $totaloffset += sprintf("%.2f", $hash->{'paid'} / 100 );
-        return 1;
-      }
       return 
         ($hash->{'recordtype'} eq '3') || #Account Trailer Record, concludes returned items
         ($hash->{'subtype'} ne '0'); #error messages, etc, too late to apply to previous entry

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/pay_batch/RBC.pm |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)