[freeside-commits] branch FREESIDE_3_BRANCH updated. bdbda2196d839c13a25da3ec5569b93d121d10f3

[Mark Wells]

The branch, FREESIDE_3_BRANCH has been updated
       via  bdbda2196d839c13a25da3ec5569b93d121d10f3 (commit)
      from  d1f18bfcf62f379dc28679481149be31eded4c9b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bdbda2196d839c13a25da3ec5569b93d121d10f3
Author: Mark Wells <mark at freeside.biz>
Date:   Fri Oct 9 00:05:25 2015 -0700

    make credit date filtering work, #37088

diff --git a/httemplate/search/cust_bill_pkg.cgi b/httemplate/search/cust_bill_pkg.cgi
index ec3785b..4ef13df 100644
--- a/httemplate/search/cust_bill_pkg.cgi
+++ b/httemplate/search/cust_bill_pkg.cgi
@@ -705,8 +705,11 @@ if ( $cgi->param('credit_begin') or $cgi->param('credit_end') ) {
                   "AND cust_credit_bill._date <= $cr_end";
 }
 
-my $credit_sub = "SELECT SUM(amount) AS credit_amount, billpkgnum
-                  FROM cust_credit_bill_pkg $credit_where GROUP BY billpkgnum";
+my $credit_sub = "SELECT SUM(cust_credit_bill_pkg.amount) AS credit_amount, billpkgnum
+                  FROM cust_credit_bill_pkg
+                  JOIN cust_credit_bill USING (creditbillnum)
+                  $credit_where
+                  GROUP BY billpkgnum";
 
 $join_pkg .= " LEFT JOIN ($credit_sub) AS item_credit
   ON (cust_bill_pkg.billpkgnum = item_credit.billpkgnum)";
diff --git a/httemplate/search/report_tax.cgi b/httemplate/search/report_tax.cgi
index 04bdf12..9e625c8 100644
--- a/httemplate/search/report_tax.cgi
+++ b/httemplate/search/report_tax.cgi
@@ -319,6 +319,7 @@ my $salescreditlink = $p. "search/cust_bill_pkg.cgi?$dateagentlink;nottax=1;cred
 if ( $params{'credit_date'} eq 'cust_credit_bill' ) {
   $salescreditlink =~ s/begin/credit_begin/;
   $salescreditlink =~ s/end/credit_end/;
+  $saleslink .= ";credit_begin=$beginning;credit_end=$ending";
 }
 #my $creditlink = $p. "search/cust_bill_pkg.cgi?$dateagentlink;credit=1;istax=1";
 #if ( $params{'credit_date'} eq 'cust_credit_bill' ) {

-----------------------------------------------------------------------

Summary of changes:
 httemplate/search/cust_bill_pkg.cgi |    7 +++++--
 httemplate/search/report_tax.cgi    |    1 +
 2 files changed, 6 insertions(+), 2 deletions(-)