[freeside-commits] branch master updated. 755f6730e6bc4b59db2041db09403c31136c814d

Jonathan Prykop jonathan at 420.am
Mon Oct 5 19:53:15 PDT 2015


The branch, master has been updated
       via  755f6730e6bc4b59db2041db09403c31136c814d (commit)
      from  5e6bfa1548ac370d2cf316e0db44785d83baa453 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 755f6730e6bc4b59db2041db09403c31136c814d
Author: Jonathan Prykop <jonathan at freeside.biz>
Date:   Mon Oct 5 21:52:43 2015 -0500

    RT37465: RBC PAD error when calculating totals [W status is now approved]

diff --git a/FS/FS/pay_batch/RBC.pm b/FS/FS/pay_batch/RBC.pm
index 644c73c..b013678 100644
--- a/FS/FS/pay_batch/RBC.pm
+++ b/FS/FS/pay_batch/RBC.pm
@@ -66,7 +66,7 @@ $name = 'RBC';
   },
   'approved'    => sub { 
       my $hash = shift;
-      $hash->{'status'} eq ' '
+      ($hash->{'status'} eq ' ') || ($hash->{'status'} eq 'W');
   },
   'declined'    => sub {
       my $hash = shift;
@@ -127,12 +127,6 @@ $name = 'RBC';
           if $hash->{'status'} eq ' '; #false laziness with 'approved' above
         return 1;
       }
-      #skipping W for now (maybe it should be declined?)
-      if ($hash->{'status'} eq 'W') {
-        #file counts this as part of total, but we skip
-        $totaloffset += sprintf("%.2f", $hash->{'paid'} / 100 );
-        return 1;
-      }
       return 
         ($hash->{'recordtype'} eq '3') || #Account Trailer Record, concludes returned items
         ($hash->{'subtype'} ne '0'); #error messages, etc, too late to apply to previous entry

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/pay_batch/RBC.pm |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)




More information about the freeside-commits mailing list