[freeside-commits] branch FREESIDE_4_BRANCH updated. 4cb2f71d4fada35301898b8611e17e317e0bede2

Ivan ivan at 420.am
Wed Jul 1 15:46:32 PDT 2015


The branch, FREESIDE_4_BRANCH has been updated
       via  4cb2f71d4fada35301898b8611e17e317e0bede2 (commit)
      from  5f724e96c2a71289c19170436c52bff85d82d0d8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4cb2f71d4fada35301898b8611e17e317e0bede2
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Wed Jul 1 15:46:31 2015 -0700

    payment total on quotes: not when recur_method eq prorate, and be more refined about disabling with sync_bill-date

diff --git a/FS/FS/quotation.pm b/FS/FS/quotation.pm
index 7bf5ecb..f820510 100644
--- a/FS/FS/quotation.pm
+++ b/FS/FS/quotation.pm
@@ -274,10 +274,12 @@ sub _items_sections {
     # but its good enough for the 99% common case of preventing totals from
     # displaying for prorate packages
     $disable_total = 1
-      if $part_pkg->plan =~ /^prorate/
-      || $part_pkg->plan eq 'agent'
-      || $part_pkg->plan =~ /^torrus/
-      || $part_pkg->option('sync_bill_date');
+      if $part_pkg->plan =~ /^(prorate|torrus|agent$)/
+      || $part_pkg->option('recur_method') eq 'prorate'
+      || ( $part_pkg->option('sync_bill_date')
+             && $self->custnum
+             && $self->cust_main->billing_pkgs #num_billing_pkgs when we have it
+         );
 
   }
   my @pkg_freq_order = keys %{ FS::Misc->pkg_freqs };

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/quotation.pm |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)




More information about the freeside-commits mailing list