[freeside-commits] branch FREESIDE_3_BRANCH updated. 76a65fb930294e3773ed87f39f0972220854fe42

[Mark Wells]

The branch, FREESIDE_3_BRANCH has been updated
       via  76a65fb930294e3773ed87f39f0972220854fe42 (commit)
      from  529413f23d545179ff07ac393713a225a78014c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 76a65fb930294e3773ed87f39f0972220854fe42
Author: Mark Wells <mark at freeside.biz>
Date:   Fri Sep 5 14:59:38 2014 -0700

    clean up last commit

diff --git a/httemplate/elements/menu.html b/httemplate/elements/menu.html
index 61cdd74..7e329cf 100644
--- a/httemplate/elements/menu.html
+++ b/httemplate/elements/menu.html
@@ -113,9 +113,8 @@ tie my %report_customers, 'Tie::IxHash';
 $report_customers{'List customers'} = [ \%report_customers_lists, 'List customers' ]
   if $curuser->access_right('List all customers');
 $report_customers{'Zip code distribution'}     = [ $fsurl. 'search/report_cust_main-zip.html', 'Zip codes by number of customers' ];
-$report_customers{'Customer signup report'}    = [ $fsurl. 'graph/report_cust_signup.html',    'New customer signups by date' ];
-$report_customers{'Signup date report'}        = [ $fsurl. 'graph/report_signupdate.html',     'Signup date report (by date of signup)' ];
-$report_customers{'Advanced customer reports'} = [ $fsurl. 'search/report_cust_main.html',     'by status, signup date, agent, etc.' ]
+$report_customers{'Customer signup report'}       = [ $fsurl. 'graph/report_cust_signup.html', 'New customer signups by date' ],
+$report_customers{'Advanced customer reports'} = [ $fsurl. 'search/report_cust_main.html', 'by status, signup date, agent, etc.' ]
   if $curuser->access_right('Advanced customer search');
 
 tie my %report_invoices_open, 'Tie::IxHash',
diff --git a/httemplate/graph/signupdate.cgi b/httemplate/graph/signupdate.cgi
index 23e4596..5b70758 100644
--- a/httemplate/graph/signupdate.cgi
+++ b/httemplate/graph/signupdate.cgi
@@ -32,23 +32,22 @@ my @count = (0) x 24;
 my %where;
 $where{'agentnum'} = $agentnum if $agentnum;
 $where{'usernum'}   = $usernum if $usernum;
-
-my $sdate = DateTime->new(
-    year       => $cgi->param('start_year'),
-    month      => $cgi->param('start_month'),
-)->epoch();
-
-my $edate = DateTime->new(
-    year       => $cgi->param('end_year'),
-    month      => ($cgi->param('end_month') % 12 + 1) # first day of the next month
-)->epoch();
-
-my $where .= " AND signupdate >= $sdate ".
-             " AND signupdate <= $edate ";
+my $sdate = $cgi->param('start_year').
+            '-'.
+            $cgi->param('start_month').
+            '-01';
+my $edate = ($cgi->param('end_year') + 
+               ($cgi->param('end_month')==12)).
+            '-'.
+            ($cgi->param('end_month') % 12 + 1).
+            '-01'; # first day of the next month
+
+my $sql = "AND signupdate >= ".str2time($sdate).
+          " AND signupdate < ".str2time($edate);
 
 foreach my $cust (qsearch({ table   => 'cust_main', 
                             hashref => \%where,
-                            extra_sql => $where } )) {
+                            extra_sql => $sql } )) {
   next if !$cust->signupdate;
   my $hour = time2str('%H',$cust->signupdate);
   $count[$hour]++;

-----------------------------------------------------------------------

Summary of changes:
 httemplate/elements/menu.html   |    5 ++---
 httemplate/graph/signupdate.cgi |   27 +++++++++++++--------------
 2 files changed, 15 insertions(+), 17 deletions(-)