[freeside-commits] branch master updated. 5a61f2f2e84350b0592fcf81feca02e82b73cc7f

[Mark Wells]

The branch, master has been updated
       via  5a61f2f2e84350b0592fcf81feca02e82b73cc7f (commit)
      from  410b1169cc6ebada005ab2771469abd1c7e824d0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5a61f2f2e84350b0592fcf81feca02e82b73cc7f
Author: Mark Wells <mark at freeside.biz>
Date:   Thu Nov 20 16:10:53 2014 -0800

    also unhide support time on transactions, #30921

diff --git a/rt/share/html/Elements/ShowCustomFields b/rt/share/html/Elements/ShowCustomFields
index 387497e..f632e68 100644
--- a/rt/share/html/Elements/ShowCustomFields
+++ b/rt/share/html/Elements/ShowCustomFields
@@ -49,31 +49,30 @@
 % if ($Table) {
 <table>
 % }
-% while ( my $CustomField = $CustomFields->Next ) {
-% my $Values = $Object->CustomFieldValues( $CustomField->Id );
-% my $count = $Values->Count;
-% next if $count == 0 and $CustomField->Disabled;
+% foreach my $set ($CustomFields, $HiddenCustomFields) {
+%   $set->GotoFirstItem;
+%   while ( my $CustomField = $set->Next ) {
+%     my $Values = $Object->CustomFieldValues( $CustomField->Id );
+%     my $count = $Values->Count;
+%     next if $count == 0 and $CustomField->Disabled;
   <tr id="CF-<%$CustomField->id%>-ShowRow">
     <td class="label"><% $CustomField->Name %>:</td>
     <td class="value">
-% unless ( $count ) {
+%     if ( $count == 0 ) {
 <i><&|/l&>(no value)</&></i>
-% } elsif ( $count == 1 ) {
-%   $print_value->( $CustomField, $Values->First );
-% } else {
+%     } elsif ( $count == 1 ) {
+%       $print_value->( $CustomField, $Values->First );
+%     } else {
 <ul>
-% while ( my $Value = $Values->Next ) {
+%       while ( my $Value = $Values->Next ) {
 <li>
-% $print_value->( $CustomField, $Value );
+%         $print_value->( $CustomField, $Value );
 </li>
-% }
+%       }
 </ul>
-% }
+%     }
     </td>
   </tr>
-%   if ( $CustomFields->IsLast ) {
-%     # switch to the other result set
-%     $CustomFields = $HiddenCustomFields;
 %   }
 % }
 % if ($Table) {
@@ -93,11 +92,10 @@ $m->callback(
 my $HiddenCustomFields = RT::CustomFields->new($session{'CurrentUser'});
 $HiddenCustomFields->LimitToChildType(ref $Object);
 $HiddenCustomFields->Limit( FIELD => 'Type', VALUE => 'TimeValue' );
-$HiddenCustomFields->Limit( FIELD => 'Disabled', VALUE => 1 );
+$HiddenCustomFields->LimitToDeleted;
 
 # don't print anything if there is no custom fields
-return unless $CustomFields->First;
-$CustomFields->GotoFirstItem;
+return unless $CustomFields->Count > 0 or $HiddenCustomFields->Count > 0;
 
 my $print_value = sub {
     my ($cf, $value) = @_;

-----------------------------------------------------------------------

Summary of changes:
 rt/share/html/Elements/ShowCustomFields |   34 +++++++++++++++----------------
 1 file changed, 16 insertions(+), 18 deletions(-)