[freeside-commits] branch FREESIDE_3_BRANCH updated. 62fe1b9b7c94cf1d05260c2a2161a1b0442b655b

[Mark Wells]

The branch, FREESIDE_3_BRANCH has been updated
       via  62fe1b9b7c94cf1d05260c2a2161a1b0442b655b (commit)
      from  7c1cc70e0d76ab8a26fc3b9dca8f20978c71e3d8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 62fe1b9b7c94cf1d05260c2a2161a1b0442b655b
Author: Mark Wells <mark at freeside.biz>
Date:   Fri May 9 14:59:39 2014 -0700

    respect "agentnum" URL param in selfservice login page, #6166, fallout from #22395

diff --git a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
index f62f1a5..71af4eb 100755
--- a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
+++ b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
@@ -181,9 +181,6 @@ unless ( $nologin_actions{$action} ) {
   } # else there is no session cookie
 
   if ( !$session_id ) {
-    # XXX why are we getting agentnum from a CGI param? surely it should 
-    # be some kind of configuration option.
-    #
     # show the login page
     $session_id = 'login'; # set state
     my $login_info = login_info( 'agentnum' => scalar($cgi->param('agentnum')) );
@@ -208,7 +205,7 @@ if ( $result->{error} && ( $result->{error} eq "Can't resume session"
   || $result->{error} eq "Expired session") ) { #ick
 
   $session_id = 'login';
-  my $login_info = login_info();
+  my $login_info = login_info( 'agentnum' => scalar($cgi->param('agentnum')) );
   do_template('login', $login_info);
   exit;
 }

-----------------------------------------------------------------------

Summary of changes:
 fs_selfservice/FS-SelfService/cgi/selfservice.cgi |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)