[freeside-commits] branch FREESIDE_3_BRANCH updated. 7344af8dd13cef85f7e58bbb258a56ed1f724e72

[Mark Wells]

The branch, FREESIDE_3_BRANCH has been updated
       via  7344af8dd13cef85f7e58bbb258a56ed1f724e72 (commit)
       via  c0afff8c23e18fc39e60219b2b48dcdde14bd5d8 (commit)
      from  4c951a8fd1eda1f31d97b8155316010695a80eaa (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7344af8dd13cef85f7e58bbb258a56ed1f724e72
Author: Mark Wells <mark at freeside.biz>
Date:   Mon May 5 09:58:09 2014 -0700

    fix zero call duration appearing on invoices when upstream_simple rating is used, #28959

diff --git a/FS/FS/cdr.pm b/FS/FS/cdr.pm
index 583e728..d3e44fe 100644
--- a/FS/FS/cdr.pm
+++ b/FS/FS/cdr.pm
@@ -999,6 +999,8 @@ sub rate_upstream_simple {
     sprintf('%.3f', $self->upstream_price),
     $opt{'svcnum'},
     'rated_classnum' => $self->calltypenum,
+    'rated_seconds'  => $self->billsec,
+    # others? upstream_*_regionname => rated_regionname is possible
   );
 }
 

commit c0afff8c23e18fc39e60219b2b48dcdde14bd5d8
Author: Mark Wells <mark at freeside.biz>
Date:   Mon May 5 09:22:25 2014 -0700

    perldoc cleanup

diff --git a/FS/FS/detail_format.pm b/FS/FS/detail_format.pm
index 2417b3a..c90d313 100644
--- a/FS/FS/detail_format.pm
+++ b/FS/FS/detail_format.pm
@@ -34,19 +34,19 @@ a subclass.
 
 OPTIONS may contain:
 
-- buffer: an arrayref to store details into.  This may avoid the need for 
-  a large copy operation at the end of processing.  However, since 
-  summary formats will produce nothing until the end of processing, 
-  C<finish> must be called after all CDRs have been appended.
+- buffer: an arrayref to store details into.  This may avoid the need for a
+large copy operation at the end of processing.  However, since summary formats
+will produce nothing until the end of processing, C<finish> must be called
+after all CDRs have been appended.
 
-- inbound: a flag telling the formatter to format CDRs for display to 
-  the receiving party, rather than the originator.  In this case, the 
-  L<FS::cdr_termination> object will be fetched and its values used for
-  rated_price, rated_seconds, rated_minutes, and svcnum.  This can be 
-  changed with the C<inbound> method.
+- inbound: a flag telling the formatter to format CDRs for display to the
+receiving party, rather than the originator.  In this case, the
+L<FS::cdr_termination> object will be fetched and its values used for
+rated_price, rated_seconds, rated_minutes, and svcnum.  This can be changed
+with the C<inbound> method.
 
-- locale: a locale string to use for static text and date formats.  This
-  is optional.
+- locale: a locale string to use for static text and date formats.  This is
+optional.
 
 =cut
 
@@ -84,6 +84,8 @@ sub new {
 
 =head1 METHODS
 
+=over 4
+
 =item inbound VALUE
 
 Set/get the 'inbound' flag.
@@ -163,12 +165,21 @@ Takes a single CDR and returns an invoice detail to describe it.
 
 By default, this maps the following fields from the CDR:
 
-rated_price       => amount
-rated_classnum    => classnum
-rated_seconds     => duration
-rated_regionname  => regionname
-accountcode       => accountcode
-startdate         => startdate
+=over 4
+
+=item rated_price       => amount
+
+=item rated_classnum    => classnum
+
+=item rated_seconds     => duration
+
+=item rated_regionname  => regionname
+
+=item accountcode       => accountcode
+
+=item startdate         => startdate
+
+=back
 
 It then calls C<columns> on the CDR to obtain a list of detail
 columns, formats them as a CSV string, and stores that in the 

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cdr.pm           |    2 ++
 FS/FS/detail_format.pm |   45 ++++++++++++++++++++++++++++-----------------
 2 files changed, 30 insertions(+), 17 deletions(-)