[freeside-commits] branch FREESIDE_3_BRANCH updated. 71f60459dbe9f803c0515bd2e54ef18f4e266fa1

[Mark Wells]

The branch, FREESIDE_3_BRANCH has been updated
       via  71f60459dbe9f803c0515bd2e54ef18f4e266fa1 (commit)
      from  0fb4ab2c74868ace9e7ac46a5ddb67c7c99597c5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 71f60459dbe9f803c0515bd2e54ef18f4e266fa1
Author: Mark Wells <mark at freeside.biz>
Date:   Mon Jun 9 16:37:30 2014 -0700

    fix checking of address range bounds, #29514, fallout from #26868

diff --git a/httemplate/edit/process/addr_range.html b/httemplate/edit/process/addr_range.html
index 5df0559..c236a73 100644
--- a/httemplate/edit/process/addr_range.html
+++ b/httemplate/edit/process/addr_range.html
@@ -13,10 +13,13 @@
         $cgi->param('end', $end->addr);
         $cgi->param('start', $start->addr);
       }
-      if ( $start + 0x7FFFFFFF <= $end ) {
+      # detect addr ranges that are too big
+      my ($one) = split('\.', $start->addr);
+      if ( $one < 128 and $start + 0x7FFFFFFF <= $end ) {
         # then this is going to overflow
-        return "Address ranges must be < 2^31 - 1 addresses long."
-      }
+        return "Address ranges must be < 2^31 - 1 addresses long.";
+      } # if the first octet is >= 128, then it's in the top half of 
+        # address space and it CAN'T be too big
 
       $cgi->param('length', $end - $start + 1);
     } else {

-----------------------------------------------------------------------

Summary of changes:
 httemplate/edit/process/addr_range.html |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)