[freeside-commits] branch FREESIDE_3_BRANCH updated. c0660bdfce760cc982a145fc3aebaaec911fc32a

[Mark Wells]

The branch, FREESIDE_3_BRANCH has been updated
       via  c0660bdfce760cc982a145fc3aebaaec911fc32a (commit)
      from  16453ebdacf7dc86d045a40eab8427414d6488e4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c0660bdfce760cc982a145fc3aebaaec911fc32a
Author: Mark Wells <mark at freeside.biz>
Date:   Thu Jun 5 13:24:10 2014 -0700

    external taxes: avoid failing when the package has taxproductnums but no default taxproductnum, fallout from #25899

diff --git a/FS/FS/part_pkg.pm b/FS/FS/part_pkg.pm
index e85da9d..036daf7 100644
--- a/FS/FS/part_pkg.pm
+++ b/FS/FS/part_pkg.pm
@@ -1390,12 +1390,19 @@ sub tax_rates {
                      $self->part_pkg_taxoverride($class);
   if (!@taxclassnums) {
     my $part_pkg_taxproduct = $self->taxproduct($class);
+    # If this isn't defined, then the class has no taxproduct designation,
+    # so return no tax rates.
+    return () if !$part_pkg_taxproduct;
+
+    # convert the taxproduct to the tax classes that might apply to it in 
+    # $geocode
     @taxclassnums = map { $_->taxclassnum }
                     grep { $_->taxable eq 'Y' } # why do we need this?
                     $part_pkg_taxproduct->part_pkg_taxrate($geocode);
   }
   return unless @taxclassnums;
 
+  # then look up the actual tax_rate entries
   warn "Found taxclassnum values of ". join(',', @taxclassnums) ."\n"
       if $DEBUG;
   my $extra_sql = "AND taxclassnum IN (". join(',', @taxclassnums) . ")";

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/part_pkg.pm |    7 +++++++
 1 file changed, 7 insertions(+)