[freeside-commits] branch master updated. 8520df0677b0b2d9b66e0d01984a2f01b4d3b04b

Ivan ivan at 420.am
Sun Jan 5 01:43:49 PST 2014


The branch, master has been updated
       via  8520df0677b0b2d9b66e0d01984a2f01b4d3b04b (commit)
      from  4d75191d9cc9ef91b82cd6ff4be96cdc8f82e480 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8520df0677b0b2d9b66e0d01984a2f01b4d3b04b
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Sun Jan 5 01:43:48 2014 -0800

    fix login with an existing session cookie, RT#25533

diff --git a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
index 1372311..f84f5d6 100755
--- a/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
+++ b/fs_selfservice/FS-SelfService/cgi/selfservice.cgi
@@ -105,7 +105,7 @@ unless ( $nologin_actions{$action} ) {
 
   my %cookies = CGI::Cookie->fetch;
 
-  my $login_rv;
+  my $login_rv = {};
 
   if ( exists($cookies{'session'}) ) {
 
@@ -178,10 +178,7 @@ unless ( $nologin_actions{$action} ) {
 
     } # else session_id ne 'login'
 
-  } else {
-    # there is no session cookie
-    $login_rv = {};
-  }
+  } # else there is no session cookie
 
   if ( !$session_id ) {
     # XXX why are we getting agentnum from a CGI param? surely it should 

-----------------------------------------------------------------------

Summary of changes:
 fs_selfservice/FS-SelfService/cgi/selfservice.cgi |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)




More information about the freeside-commits mailing list