[freeside-commits] branch FREESIDE_3_BRANCH updated. 2c193dace8bcfc3e2b75bf6b1d28cf04bc45e2a0

Mark Wells mark at 420.am
Fri Apr 11 08:20:31 PDT 2014


The branch, FREESIDE_3_BRANCH has been updated
       via  2c193dace8bcfc3e2b75bf6b1d28cf04bc45e2a0 (commit)
      from  58323c34f3dd367739d9b3c4c67e5b147f9fc882 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2c193dace8bcfc3e2b75bf6b1d28cf04bc45e2a0
Author: Mark Wells <mark at freeside.biz>
Date:   Fri Apr 11 08:19:55 2014 -0700

    fix accidental resetting of TimeWorked value, #28459

diff --git a/rt/lib/RT/Interface/Web_Vendor.pm b/rt/lib/RT/Interface/Web_Vendor.pm
index 245df12..c9bff6f 100644
--- a/rt/lib/RT/Interface/Web_Vendor.pm
+++ b/rt/lib/RT/Interface/Web_Vendor.pm
@@ -288,8 +288,10 @@ sub ProcessTicketBasics {
     # fields to empty strings, but internally change the values 
     # to zero.  This is sloppy and causes some problems.
     foreach my $field (qw(TimeWorked TimeEstimated TimeLeft)) {
-      $ARGSRef->{$field} =~ s/\s//g;
-      $ARGSRef->{$field} ||= 0;
+      if (exists $ARGSRef->{$field}) {
+        $ARGSRef->{$field} =~ s/\s//g;
+        $ARGSRef->{$field} ||= 0;
+      }
     }
 
     my @results = UpdateRecordObject(

-----------------------------------------------------------------------

Summary of changes:
 rt/lib/RT/Interface/Web_Vendor.pm |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)




More information about the freeside-commits mailing list