[freeside-commits] branch master updated. 686ac9dce198f8ddf01e507b3289485b4ef20946

Ivan ivan at 420.am
Wed May 15 02:10:14 PDT 2013


The branch, master has been updated
       via  686ac9dce198f8ddf01e507b3289485b4ef20946 (commit)
      from  c60a792261878dd4148471b10e3f82980cea4b1e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 686ac9dce198f8ddf01e507b3289485b4ef20946
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Wed May 15 02:09:30 2013 -0700

    payment voids exist, time for deletepayments to go

diff --git a/FS/FS/Conf.pm b/FS/FS/Conf.pm
index 0a9b781..0784cd0 100644
--- a/FS/FS/Conf.pm
+++ b/FS/FS/Conf.pm
@@ -1066,13 +1066,6 @@ sub reason_type_options {
   },
 
   {
-    'key'         => 'deletepayments',
-    'section'     => 'billing',
-    'description' => 'Enable deletion of unclosed payments.  Really, with voids this is pretty much not recommended in any situation anymore.  Be very careful!  Only delete payments that were data-entry errors, not adjustments.  Optionally specify one or more comma-separated email addresses to be notified when a payment is deleted.',
-    'type'        => [qw( checkbox text )],
-  },
-
-  {
     'key'         => 'deletecredits',
     #not actually deprecated yet
     #'section'     => 'deprecated',
diff --git a/FS/FS/cust_pay.pm b/FS/FS/cust_pay.pm
index da91439..86fcf9b 100644
--- a/FS/FS/cust_pay.pm
+++ b/FS/FS/cust_pay.pm
@@ -459,38 +459,6 @@ sub delete {
     return $error;
   }
 
-  if (    $conf->exists('deletepayments')
-       && $conf->config('deletepayments') ne '' ) {
-
-    my $cust_main = $self->cust_main;
-
-    my $error = send_email(
-      'from'    => $conf->config('invoice_from', $self->cust_main->agentnum),
-                                 #invoice_from??? well as good as any
-      'to'      => $conf->config('deletepayments'),
-      'subject' => 'FREESIDE NOTIFICATION: Payment deleted',
-      'body'    => [
-        "This is an automatic message from your Freeside installation\n",
-        "informing you that the following payment has been deleted:\n",
-        "\n",
-        'paynum: '. $self->paynum. "\n",
-        'custnum: '. $self->custnum.
-          " (". $cust_main->last. ", ". $cust_main->first. ")\n",
-        'paid: $'. sprintf("%.2f", $self->paid). "\n",
-        'date: '. time2str("%a %b %e %T %Y", $self->_date). "\n",
-        'payby: '. $self->payby. "\n",
-        'payinfo: '. $self->paymask. "\n",
-        'paybatch: '. $self->paybatch. "\n",
-      ],
-    );
-
-    if ( $error ) {
-      $dbh->rollback if $oldAutoCommit;
-      return "can't send payment deletion notification: $error";
-    }
-
-  }
-
   $dbh->commit or die $dbh->errstr if $oldAutoCommit;
 
   '';

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/Conf.pm     |    7 -------
 FS/FS/cust_pay.pm |   32 --------------------------------
 2 files changed, 0 insertions(+), 39 deletions(-)




More information about the freeside-commits mailing list