[freeside-commits] branch FREESIDE_2_3_BRANCH updated. ee08941821939b8fd1b1237634127131daa529b2

[Ivan]

The branch, FREESIDE_2_3_BRANCH has been updated
       via  ee08941821939b8fd1b1237634127131daa529b2 (commit)
      from  ddcb4b190e77cb39dee3ba519c52f301e75394d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ee08941821939b8fd1b1237634127131daa529b2
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Fri Mar 22 20:25:03 2013 -0700

    don't call realtime_collect for prepaid cards, fixes signup error in 3.x, RT#22151

diff --git a/FS/FS/ClientAPI/Signup.pm b/FS/FS/ClientAPI/Signup.pm
index f17752a..b11e36f 100644
--- a/FS/FS/ClientAPI/Signup.pm
+++ b/FS/FS/ClientAPI/Signup.pm
@@ -762,13 +762,15 @@ sub new_customer {
     #     " new customer: $bill_error"
     #  if $bill_error;
 
-    $bill_error = $cust_main->realtime_collect(
-       method        => FS::payby->payby2bop( $packet->{payby} ),
-       depend_jobnum => $placeholder->jobnum,
-       selfservice   => 1,
-    );
-    #warn "$me error collecting from new customer: $bill_error"
-    #  if $bill_error;
+    unless ( $packet->{payby} eq 'PREPAY' ) {
+      $bill_error = $cust_main->realtime_collect(
+         method        => FS::payby->payby2bop( $packet->{payby} ),
+         depend_jobnum => $placeholder->jobnum,
+         selfservice   => 1,
+      );
+      #warn "$me error collecting from new customer: $bill_error"
+      #  if $bill_error;
+    }
 
     if ($bill_error && ref($bill_error) eq 'HASH') {
       return { 'error' => '_collect',

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/ClientAPI/Signup.pm |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)