[freeside-commits] branch master updated. be49cf6b227c698d16238d1be6c9c7785fa5870d

Ivan ivan at 420.am
Tue Mar 19 15:42:41 PDT 2013


The branch, master has been updated
       via  be49cf6b227c698d16238d1be6c9c7785fa5870d (commit)
       via  43c9d84ae27496b56bb79c6304ae94847318af5b (commit)
       via  56322f5e308acd91b375447a66e970d32a8383b0 (commit)
      from  c917013f3e2232be3c3303e8cabef365096da979 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit be49cf6b227c698d16238d1be6c9c7785fa5870d
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Tue Mar 19 15:42:39 2013 -0700

    fix report day selection on daylight savings boundaries, RT#21879

diff --git a/FS/FS/Misc/DateTime.pm b/FS/FS/Misc/DateTime.pm
index 99ff409..2fff906 100644
--- a/FS/FS/Misc/DateTime.pm
+++ b/FS/FS/Misc/DateTime.pm
@@ -2,8 +2,8 @@ package FS::Misc::DateTime;
 
 use base qw( Exporter );
 use vars qw( @EXPORT_OK );
-use POSIX;
 use Carp;
+use Time::Local;
 use Date::Parse;
 use DateTime::Format::Natural;
 use FS::Conf;
@@ -49,7 +49,7 @@ sub parse_datetime {
       #carp "WARNING: can't parse date: ". $parser->error;
       #return '';
       #huh, very common, we still need the "partially" (fully enough for our purposes) parsed date.
-      $dt->epoch;
+      return $dt->epoch;
     }
   } else {
     return str2time($string, $tz);
@@ -69,7 +69,7 @@ sub day_end {
 
     my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) =
         localtime($time);
-    mktime(59,59,23,$mday,$mon,$year,$wday,$yday,$isdst);
+    timelocal(59,59,23,$mday,$mon,$year);
 }
 
 =back

commit 43c9d84ae27496b56bb79c6304ae94847318af5b
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Tue Mar 19 15:22:15 2013 -0700

    normalize capitalization

diff --git a/httemplate/elements/menu.html b/httemplate/elements/menu.html
index 34f660e..00c43bb 100644
--- a/httemplate/elements/menu.html
+++ b/httemplate/elements/menu.html
@@ -236,7 +236,7 @@ tie my %report_packages, 'Tie::IxHash';
 $report_packages{'Package definitions (by # active)'} =  [ $fsurl.'browse/part_pkg.cgi?active=1', 'Package definitions by number of active packages' ]
   if    $curuser->access_right('Edit package definitions')
      || $curuser->access_right('Edit global package definitions');
-$report_packages{'Package Costs Report'} = [ $fsurl.'graph/report_cust_pkg_cost.html', 'Package setup and recurring costs graph' ]
+$report_packages{'Package costs'} = [ $fsurl.'graph/report_cust_pkg_cost.html', 'Package setup and recurring costs graph' ]
   if $curuser->access_right('Financial reports');
 $report_packages{'separator'} =  ''
   if keys %report_packages;

commit 56322f5e308acd91b375447a66e970d32a8383b0
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Tue Mar 19 15:21:57 2013 -0700

    remove warning

diff --git a/httemplate/search/elements/cust_pay_or_refund.html b/httemplate/search/elements/cust_pay_or_refund.html
index 9f83d54..3e5d504 100755
--- a/httemplate/search/elements/cust_pay_or_refund.html
+++ b/httemplate/search/elements/cust_pay_or_refund.html
@@ -406,7 +406,7 @@ if ( $cgi->param('magic') ) {
     }
 
     my($beginning, $ending) = FS::UI::Web::parse_beginning_ending($cgi);
-warn $beginning;
+
     push @search, "_date >= $beginning ",
                   "_date <= $ending";
 

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/Misc/DateTime.pm                             |    6 +++---
 httemplate/elements/menu.html                      |    2 +-
 httemplate/search/elements/cust_pay_or_refund.html |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)




More information about the freeside-commits mailing list