[freeside-commits] branch master updated. 5221eadfdb1a8faa0b46e8a8577876fb8d67fb37

[Ivan]

The branch, master has been updated
       via  5221eadfdb1a8faa0b46e8a8577876fb8d67fb37 (commit)
      from  f8b3592d2808827dcef2b5d4821d0757bab5c518 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5221eadfdb1a8faa0b46e8a8577876fb8d67fb37
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Sun Dec 29 18:23:02 2013 -0800

    still report errant AUTOLOAD triggering in the new world of FKs, RT#13971

diff --git a/FS/FS/Record.pm b/FS/FS/Record.pm
index 835b73d..39a3920 100644
--- a/FS/FS/Record.pm
+++ b/FS/FS/Record.pm
@@ -979,6 +979,9 @@ sub AUTOLOAD {
   my($field)=$AUTOLOAD;
   $field =~ s/.*://;
 
+  confess "errant AUTOLOAD $field for $self (arg $value)"
+    unless blessed($self) && $self->can('setfield');
+
   #$fk_method_cache{$self->table} ||= fk_methods($self->table);
   if ( exists($fk_method_cache{$self->table}->{$field}) ) {
 
@@ -1006,12 +1009,8 @@ sub AUTOLOAD {
   }
 
   if ( defined($value) ) {
-    confess "errant AUTOLOAD $field for $self (arg $value)"
-      unless blessed($self) && $self->can('setfield');
     $self->setfield($field,$value);
   } else {
-    confess "errant AUTOLOAD $field for $self (no args)"
-      unless blessed($self) && $self->can('getfield');
     $self->getfield($field);
   }    
 }

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/Record.pm |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)