[freeside-commits] branch master updated. bd97a17f72682a1ad4ecf4db2eb6747cc0bb4981

[Ivan]

The branch, master has been updated
       via  bd97a17f72682a1ad4ecf4db2eb6747cc0bb4981 (commit)
       via  35e5b12fb55f229edd16bed66e21c5806b8d3b7e (commit)
       via  9005d0ad058eee59bacafe26217ed4fda2da1800 (commit)
      from  98ea745e4b55a38ad8b5ba3749c56327d641d65d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bd97a17f72682a1ad4ecf4db2eb6747cc0bb4981
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Sun Aug 11 16:31:51 2013 -0700

    fix endless redirect loops and bogus results messages on ticket view, RT#23309

diff --git a/rt/lib/RT/Interface/Web_Vendor.pm b/rt/lib/RT/Interface/Web_Vendor.pm
index a5f5b88..7a4804b 100644
--- a/rt/lib/RT/Interface/Web_Vendor.pm
+++ b/rt/lib/RT/Interface/Web_Vendor.pm
@@ -257,16 +257,17 @@ sub ProcessTicketBasics {
         WillResolve
     );
 
-    # the UI for editing WillResolve through Ticket Basics should allow 
-    # setting it to null
-    my $to_date = delete($ARGSRef->{'WillResolve_Date'});
-    my $DateObj = RT::Date->new($session{'CurrentUser'});
-    if ( $to_date ) {
-        $DateObj->Set(Format => 'unknown', Value => $to_date);
-    } else {
-        $DateObj->Set(Value => 0);
-    }
-    $ARGSRef->{'WillResolve'} = $DateObj->ISO;
+# causes endless redirect loops and "WillResolve changed from Not set to Not set" on ticket view?
+#    # the UI for editing WillResolve through Ticket Basics should allow 
+#    # setting it to null
+#    my $to_date = delete($ARGSRef->{'WillResolve_Date'});
+#    my $DateObj = RT::Date->new($session{'CurrentUser'});
+#    if ( $to_date ) {
+#        $DateObj->Set(Format => 'unknown', Value => $to_date);
+#    } else {
+#        $DateObj->Set(Value => 0);
+#    }
+#    $ARGSRef->{'WillResolve'} = $DateObj->ISO;
 
     if ( $ARGSRef->{'Queue'} and ( $ARGSRef->{'Queue'} !~ /^(\d+)$/ ) ) {
         my $tempqueue = RT::Queue->new($RT::SystemUser);

commit 35e5b12fb55f229edd16bed66e21c5806b8d3b7e
Merge: 9005d0a 98ea745
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Sun Aug 11 16:18:24 2013 -0700

    Merge branch 'master' of git.freeside.biz:/home/git/freeside


commit 9005d0ad058eee59bacafe26217ed4fda2da1800
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Sun Aug 11 16:18:18 2013 -0700

    doc

diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index 01eaf62..d885abf 100644
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -1450,10 +1450,8 @@ field).
 
 Can be set true to adjust the next bill date forward by
 the amount of time the account was inactive.  This was set true by default
-since 1.4.2 and 1.5.0pre6; however, starting with 1.7.0 this needs to be
-explicitly requested.  Price plans for which this makes sense (anniversary-date
-based than prorate or subscription) could have an option to enable this
-behaviour?
+in the past (from 1.4.2 and 1.5.0pre6 through 1.7.0), but now needs to be
+explicitly requested with this option or in the price plan.
 
 =back
 

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_pkg.pm                 |    6 ++----
 rt/lib/RT/Interface/Web_Vendor.pm |   21 +++++++++++----------
 2 files changed, 13 insertions(+), 14 deletions(-)