[freeside-commits] branch FREESIDE_2_3_BRANCH updated. b77cf31ec6cf130ae8f19265fec49b62484060fb

[Ivan]

The branch, FREESIDE_2_3_BRANCH has been updated
       via  b77cf31ec6cf130ae8f19265fec49b62484060fb (commit)
      from  351a90553db4e68cc8855be30310cfd39cd63e65 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b77cf31ec6cf130ae8f19265fec49b62484060fb
Author: Ivan Kohler <ivan at freeside.biz>
Date:   Thu May 3 13:57:55 2012 -0700

    when un-cancelling a package, errors re-provisioning services are not fatal, RT#17518

diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index f01c5c3..9d81c67 100644
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -889,7 +889,9 @@ sub cancel_if_expired {
 locationnum, (other fields?).  Attempts to re-provision cancelled services
 using history information (errors at this stage are not fatal).
 
-cust_pkg: pass a scalar reference, will be filled in with
+cust_pkg: pass a scalar reference, will be filled in with the new cust_pkg object
+
+svc_fatal: service provisioning errors are fatal
 
 svc_errors: pass an array reference, will be filled in with any provisioning errors
 
@@ -972,7 +974,7 @@ sub uncancel {
     }
 
     my $svc_error = $svc_x->insert;
-    if ( $svc_error ) { #&& $options{svc_fatal} ) {
+    if ( $svc_error && $options{svc_fatal} ) {
       $dbh->rollback if $oldAutoCommit;
       return $error;
     }

-----------------------------------------------------------------------

Summary of changes:
 FS/FS/cust_pkg.pm |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)